Skip to content

Laravel 12.x Shift #2080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lancepioch wants to merge 10 commits into from
+31 −9
Closed

Laravel 12.x Shift #2080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5db3346
Slim `lang` files
laravel-shift Jan 7, 2026
f4dc7d8
Adopt new PHP attributes in models
laravel-shift Jan 7, 2026
42e1c48
Default config files
laravel-shift Jan 7, 2026
12a8257
Shift `ENV` variables
laravel-shift Jan 7, 2026
63f9ada
Add new Laravel `composer run dev` script
laravel-shift Jan 7, 2026
82ac348
Bump Composer dependencies
laravel-shift Jan 7, 2026
4d5d879
Bump NPM dependencies
laravel-shift Jan 7, 2026
5db7ca5
Adopt Laravel type hints
laravel-shift Jan 7, 2026
ddf616b
Shift cleanup
laravel-shift Jan 7, 2026
3be092b
Revert "Default config files"
lancepioch Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/Console/Commands/Overrides/ConfigCacheCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ class ConfigCacheCommand extends BaseConfigCacheCommand
/**
* Prevent config from being cached
*/
public function handle()
public function handle(): void
{
$this->components->warn('Configuration caching has been disabled.');

Expand Down
7 changes: 5 additions & 2 deletions app/Models/ActivityLog.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
use Filament\Facades\Filament;
use Filament\Support\Contracts\HasIcon;
use Filament\Support\Contracts\HasLabel;
use Illuminate\Database\Eloquent\Attributes\Scope;
use Illuminate\Database\Eloquent\Builder;
use Illuminate\Database\Eloquent\MassPrunable;
use Illuminate\Database\Eloquent\Model;
Expand Down Expand Up @@ -108,15 +109,17 @@ public function apiKey(): HasOne
return $this->hasOne(ApiKey::class, 'id', 'api_key_id');
}

public function scopeForEvent(Builder $builder, string $action): Builder
#[Scope]
protected function forEvent(Builder $builder, string $action): Builder
{
return $builder->where('event', $action);
}

/**
* Scopes a query to only return results where the actor is a given model.
*/
public function scopeForActor(Builder $builder, Model $actor): Builder
#[Scope]
protected function forActor(Builder $builder, Model $actor): Builder
{
return $builder->whereMorphedTo('actor', $actor);
}
Expand Down
23 changes: 21 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"filament/filament": "~4.0",
"gboquizosanchez/filament-log-viewer": "^2.1",
Copy link
Member

@rmartinoscar rmartinoscar Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump this to v2.2.1

Suggested change
"gboquizosanchez/filament-log-viewer": "^2.1",
"gboquizosanchez/filament-log-viewer": "^2.2",

"guzzlehttp/guzzle": "^7.10",
"laravel/framework": "^12.37",
"laravel/framework": "^12.45",
"laravel/helpers": "^1.7",
"laravel/sanctum": "^4.2",
"laravel/socialite": "^5.23",
Expand Down Expand Up @@ -83,6 +83,25 @@
"post-install-cmd": [
"php -r \"file_exists('.env') || copy('.env.example', '.env');\"",
"php artisan p:plugin:composer"
],
"dev": [
"Composer\\Config::disableProcessTimeout",
"npx concurrently -c \"#93c5fd,#c4b5fd,#fb7185,#fdba74\" \"php artisan serve\" \"php artisan queue:listen --tries=1\" \"php artisan pail --timeout=0\" \"npm run dev\" --names=server,queue,logs,vite --kill-others"
],
"setup": [
"composer install",
"@php -r \"file_exists('.env') || copy('.env.example', '.env');\"",
"@php artisan key:generate",
"@php artisan migrate --force",
"npm install",
"npm run build"
],
"test": [
"@php artisan config:clear --ansi",
"@php artisan test"
],
"pre-package-uninstall": [
"Illuminate\\Foundation\\ComposerScripts::prePackageUninstall"
Comment on lines +86 to +104
Copy link
Member

@rmartinoscar rmartinoscar Jan 7, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
],
"dev": [
"Composer\\Config::disableProcessTimeout",
"npx concurrently -c \"#93c5fd,#c4b5fd,#fb7185,#fdba74\" \"php artisan serve\" \"php artisan queue:listen --tries=1\" \"php artisan pail --timeout=0\" \"npm run dev\" --names=server,queue,logs,vite --kill-others"
],
"setup": [
"composer install",
"@php -r \"file_exists('.env') || copy('.env.example', '.env');\"",
"@php artisan key:generate",
"@php artisan migrate --force",
"npm install",
"npm run build"
],
"test": [
"@php artisan config:clear --ansi",
"@php artisan test"
],
"pre-package-uninstall": [
"Illuminate\\Foundation\\ComposerScripts::prePackageUninstall"

This was purposely removed in 78aa7d2 and #1994 got refused aswell.

]
},
"config": {
Expand All @@ -98,4 +117,4 @@
},
"minimum-stability": "stable",
"prefer-stable": true
}
}
4 changes: 1 addition & 3 deletions lang/en/auth.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,10 @@
|
*/

'failed' => 'These credentials do not match our records.',
'failed-two-factor' => 'Incorrect 2FA Code',
'two-factor-code' => 'Two Factor Code',
'two-factor-hint' => 'You may use backup codes if you lost access to your device.',
'password' => 'The provided password is incorrect.',
'throttle' => 'Too many login attempts. Please try again in :seconds seconds.',

'2fa_must_be_enabled' => 'The administrator has required that 2-Factor Authentication must be enabled for your account in order to use the Panel.',

];
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"@tailwindcss/vite": "^4.1.4",
"autoprefixer": "^10.4.21",
"concurrently": "^9.0.1",
"laravel-vite-plugin": "^1.0",
"laravel-vite-plugin": "^2.0.0",
Copy link

@coderabbitai coderabbitai bot Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🌐 Web query:

laravel-vite-plugin 2.0.0 breaking changes migration guide

💡 Result:

Short migration summary for laravel-vite-plugin → 2.0.0 and what to change

Sources: [1][2][3]

What changed (breaking / notable)

  • Drops CJS build / ESM-first: plugin no longer ships a CommonJS build — projects must use ESM or .cjs config files. [2][1]
  • Node.js support bumped / older Node removed: older Node (14/15/16/17/19, etc.) support removed — run on a supported Node for the Vite version you use. [2]
  • server.https boolean removed: boolean value for vite.config server.https is no longer supported (use the object form or other TLS options). [2]
  • Depend on matching Vite major: v2 of the plugin expects newer Vite/plugin versions — you must upgrade Vite and any Vite plugins (Vue/React plugins) to compatible versions. [2]
  • Misc developer conveniences: new commands and default refresh/watch paths (e.g., app/Livewire/**) and SSR manifest output behaviour changed in prior major moves—check your refresh/watch settings if you rely on defaults. [2]

Minimum migration steps

  1. Update packages:
    • npm install --save-dev vite@^ laravel-vite-plugin@^2.0.0 and update any @vitejs plugins to their matching compatible versions. Confirm exact Vite major required by your plugin release notes. [2][1]
  2. Make package.json ESM (if not already):
    • npm pkg set type=module or keep CJS config files as .cjs when you must keep CommonJS in configs. [2]
  3. Update vite.config.*:
    • Replace any server.https: true/false boolean with the supported object form or your TLS setup.
    • Convert any require(...) usage in vite.config to ESM import, or rename file to vite.config.cjs and keep require. [2]
  4. Check Node version:
    • Run on a Node version supported by the Vite major you installed (upgrade Node if needed). [2]
  5. Verify hot/hotFile and filesystem paths:
    • If you use hotFile or hot-related features, confirm directories exist and plugin behaviour (hotFile path) after upgrade; some fixes were released after 2.0.0. [1][3]
  6. Test dev and build:
    • Run dev server and production build; confirm manifest/SSR output and asset URLs used by your Laravel views still match (update blade calls if manifest structure or file names changed).

If you want, I can:

  • fetch the exact Vite version compatibility and the plugin’s full changelog/upgrade guide (link to the plugin CHANGELOG / release notes) and produce a patch/diff for your vite.config and package.json. Which repo/version of Vite are you upgrading from?

Sources
[1] npm/jsDelivr package listing for laravel-vite-plugin (shows v2.0.0).
[2] Extracts from the plugin upgrade notes / changelog (noting CJS removal, server.https boolean removal, Node drops, and upgrade steps).
[3] Yarn/npm changelog entries and follow-up fixes referencing post-2.0.0 patch (hotFile parent directory fix).

Address laravel-vite-plugin v2.0.0 breaking changes before deploying.

The upgrade from ^1.0 to ^2.0.0 introduces several breaking changes:

  • ESM-only: Plugin no longer ships CommonJS builds—your project must use ESM or configure Vite config as .cjs files
  • Node.js version bump: Drops support for Node 14, 15, 16, 17, 19—verify your Node version matches the minimum required by your Vite version
  • server.https config change: Boolean values (e.g., server.https: true) no longer supported—use object form instead
  • Vite version compatibility: Requires upgrading Vite and related plugins (@vitejs, Vue, React) to compatible major versions
  • Default paths updated: Refresh and watch paths changed (e.g., new defaults include app/Livewire/**)

Update vite.config.js (or rename to vite.config.cjs if keeping CommonJS), upgrade Vite and plugins, verify Node version, and test both dev and production builds before merging.

🤖 Prompt for AI Agents 
In @package.json at line 14, The package.json now pins "laravel-vite-plugin":
"^2.0.0" which is ESM-only and has breaking changes; update package.json and
project config by either downgrading the plugin or upgrading Vite and related
plugins (vite, @vitejs/*, vue/react plugins) to compatible majors, ensure your
Node version meets the new minimum, and modify vite.config.js (or rename to
vite.config.cjs if you must keep CommonJS) to address ESM requirements and the
new server.https shape (replace boolean server.https: true with an object form),
verify any default path changes (e.g., refresh/watch patterns like
app/Livewire/**) and run full dev and production builds to confirm no
regressions.

Copy link
Member

@rmartinoscar rmartinoscar Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not v2.0.1 ?

Suggested change
"laravel-vite-plugin": "^2.0.0",
"laravel-vite-plugin": "^2.0.1",

"prettier": "^3.4.2",
"tailwindcss": "^4.1.4",
"vite": "7.1.11"
Expand Down
2 changes: 2 additions & 0 deletions phpunit.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
<env name="APP_ENV" value="testing"/>
<env name="APP_MAINTENANCE_DRIVER" value="file"/>
<env name="BCRYPT_ROUNDS" value="4"/>
<env name="BROADCAST_CONNECTION" value="null"/>
<env name="CACHE_STORE" value="array"/>
<env name="DB_CONNECTION" value="sqlite"/>
<env name="DB_DATABASE" value="testing.sqlite"/>
Expand All @@ -25,6 +26,7 @@
<env name="QUEUE_CONNECTION" value="sync"/>
<env name="SESSION_DRIVER" value="array"/>
<env name="TELESCOPE_ENABLED" value="false"/>
<env name="NIGHTWATCH_ENABLED" value="false"/>
</php>
<source>
<include>
Expand Down
Loading