Skip to content

Conversation

@Boy132
Copy link
Member

@Boy132 Boy132 commented Jan 29, 2026

Followup for #2134

Also closes #2147

@Boy132 Boy132 self-assigned this Jan 29, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 29, 2026

📝 Walkthrough

Walkthrough

This PR consolidates Filament action UI configuration by centralizing tooltip and icon logic in the service provider, simplifying toolbar CreateActions across resources, renaming certain actions with an exclude_ prefix, and enhancing navigation and form actions with tooltips. These changes address visibility issues with action buttons and standardize UI presentation patterns.

Changes

Cohort / File(s) Summary
Toolbar CreateAction Simplification
app/Filament/Admin/Resources/ApiKeys/ApiKeyResource.php, app/Filament/Admin/Resources/DatabaseHosts/DatabaseHostResource.php, app/Filament/Admin/Resources/Eggs/Pages/ListEggs.php, app/Filament/Admin/Resources/Mounts/MountResource.php, app/Filament/Admin/Resources/Nodes/Pages/ListNodes.php, app/Filament/Admin/Resources/Roles/RoleResource.php, app/Filament/Admin/Resources/Servers/Pages/ListServers.php, app/Filament/Admin/Resources/Webhooks/WebhookResource.php
Removed hiddenLabel() and explicit icon(TablerIcon::Plus) customization from CreateAction in toolbar, allowing default presentation to be applied globally.
Navigation and Submit Action Enhancement
app/Filament/Admin/Resources/Nodes/Pages/CreateNode.php, app/Filament/Admin/Resources/Servers/Pages/CreateServer.php
Added tooltips to next/previous navigation actions derived from action labels; updated submit button to use icon-button with enhanced sizing and tooltip configuration.
Action Identifier Renaming
app/Filament/Admin/Resources/Servers/Pages/EditServer.php, app/Filament/Server/Pages/Settings.php
Renamed action identifiers with exclude_ prefix: toggleInstallexclude_toggle_install, toggleSuspendexclude_toggle_suspend, transferexclude_transfer, reinstallexclude_reinstall. Also added tooltip to hint_random suffix action on name field.
Webhook Action Configuration
app/Filament/Admin/Resources/Webhooks/Pages/EditWebhookConfiguration.php, app/Filament/Admin/Resources/Webhooks/WebhookResource.php
Changed test_now action from label to tooltip with added TestPipe icon; updated reset_headers action to use tooltip instead of label and replaced icon from trash (Heroicon) to TablerRestore.
Global Filament Action Configuration
app/Providers/Filament/FilamentServiceProvider.php
Replaced static translation tooltips with dynamic $action->getLabel() for delete, copy, and password actions; added icons to CreateAction (Plus), EditAction (Pencil), and ViewAction (Eye); added oauth_ to excluded action prefixes to prevent unwanted icon button enhancement.
Translation Updates
lang/en/admin/webhook.php
Removed test_now_help translation key; updated test_now from 'Test Now' to 'Test now'.

Possibly related PRs

  • #1900: Modifies identical Filament action configurations across the same resource files but in the opposite direction (adding vs. removing icon/label customizations).
  • #2134: Updates the same toolbar CreateAction and form action patterns in overlapping resource files with contrasting UI enhancement strategies.
  • #1684: Makes related UI builder changes across Filament resources affecting toolbar and form action configurations.
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 62.50% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Invisible button and tooltip fixes' accurately summarizes the main changes in the PR: addressing visibility issues with buttons and adding/updating tooltips across multiple Filament resource files.
Description check ✅ Passed The description references linked issues #2134 and #2147, which are directly related to the changeset addressing invisible buttons and tooltip improvements.
Linked Issues check ✅ Passed The code changes directly address issue #2147 by renaming the reinstall action identifier to 'exclude_reinstall' and removing hiddenLabel() calls that were causing buttons to be invisible, while also adding tooltips as required.
Out of Scope Changes check ✅ Passed All changes are scoped to fixing invisible buttons and adding/improving tooltips in Filament UI components, with no unrelated modifications present.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@app/Filament/Admin/Resources/Webhooks/Pages/EditWebhookConfiguration.php`:
- Around line 28-33: The test_now header action (Action::make('test_now')) is
missing ->hiddenLabel(), causing an empty label gap; update the action chain
where Action::make('test_now') is defined (the call that already uses
->tooltip(...), ->icon(TablerIcon::TestPipe), ->disabled(...), ->action(...))
and append ->hiddenLabel() to that fluent chain to match the sibling save action
and CreateWebhookConfiguration pattern.
🧹 Nitpick comments (2)
app/Filament/Admin/Resources/Servers/Pages/EditServer.php (1)

262-264: Localize the “Random” tooltip text.
Consider using a translation key (or an action label–driven tooltip) to keep i18n consistent.

app/Filament/Admin/Resources/Servers/Pages/CreateServer.php (1)

107-112: Localize the “Random” tooltip text.
Consider using a translation key (or an action label–driven tooltip) to keep i18n consistent.

@Boy132 Boy132 merged commit 833294b into main Jan 29, 2026
32 checks passed
@Boy132 Boy132 deleted the boy132/fix-invisible-buttons branch January 29, 2026 14:37
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reinstall button invisible

3 participants