-
-
Notifications
You must be signed in to change notification settings - Fork 257
Invisible button and tooltip fixes #2149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThis PR consolidates Filament action UI configuration by centralizing tooltip and icon logic in the service provider, simplifying toolbar CreateActions across resources, renaming certain actions with an Changes
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@app/Filament/Admin/Resources/Webhooks/Pages/EditWebhookConfiguration.php`:
- Around line 28-33: The test_now header action (Action::make('test_now')) is
missing ->hiddenLabel(), causing an empty label gap; update the action chain
where Action::make('test_now') is defined (the call that already uses
->tooltip(...), ->icon(TablerIcon::TestPipe), ->disabled(...), ->action(...))
and append ->hiddenLabel() to that fluent chain to match the sibling save action
and CreateWebhookConfiguration pattern.
🧹 Nitpick comments (2)
app/Filament/Admin/Resources/Servers/Pages/EditServer.php (1)
262-264: Localize the “Random” tooltip text.
Consider using a translation key (or an action label–driven tooltip) to keep i18n consistent.app/Filament/Admin/Resources/Servers/Pages/CreateServer.php (1)
107-112: Localize the “Random” tooltip text.
Consider using a translation key (or an action label–driven tooltip) to keep i18n consistent.
Followup for #2134
Also closes #2147