Skip to content

Conversation

@lancepioch
Copy link
Member

  1. Type in username/email
  2. Hit tab to go to password input
  3. Notice it works now

@lancepioch lancepioch self-assigned this Jan 30, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 30, 2026

📝 Walkthrough

Walkthrough

The login form's password field now has an explicit tabindex attribute set to 2 via an overridden method that extends parent functionality, improving keyboard navigation without modifying core authentication logic.

Changes

Cohort / File(s) Summary
Password Field Tab Order
app/Filament/Pages/Auth/Login.php
Added getPasswordFormComponent() method override to set password input field tabindex to 2 for improved keyboard navigation ordering.
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title directly describes the main change: fixing tabbing behavior from username to password on the login form, which matches the changeset.
Description check ✅ Passed The description is related to the changeset as it explains the tab behavior fix with reproduction steps for the login form.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants