Skip to content

Conversation

@suds-mcduff
Copy link

Description

Forge egg had URL references that were incorrect leading to curl not downloading the installer.
Fixed URL references.
Not able to fix installs for MC versions lower than 1.5.2 since Forge shipped has a zip
Added URL references for all versions though in case someone else wants to use the fixed URLs and make installs below 1.5.2 work

Checklist for all submissions

  • [x ] Have you followed the guidelines in our Contributing document?
  • [x ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [x ] Have you tested and reviewed your changes with confidence that everything works?
  • [x ] Did you branch your changes and PR from that branch and not from your master branch?
    • If not, why?:
  • You verify that the start command applied does not use a shell script
    • [x ] If some script is needed then it is part of a current yolk or a PR to add one
  • [x ] The egg was exported from the panel

@suds-mcduff
Copy link
Author

New to contributing, let me know if there's any issues with my MR

@suds-mcduff suds-mcduff marked this pull request as ready for review March 9, 2025 04:59
@QuintenQVD0
Copy link
Contributor

New to contributing, let me know if there's any issues with my MR

You changed the author what is not allowed. You overwrote a pelican egg with a pterodactyl egg what is not allowed

@suds-mcduff
Copy link
Author

Ah sorry about the author, I was confused on that one and thought I had to put my email if I updated it. About the pterodactyl egg, not sure about that it looks like the old script was a pterodactyl egg and the one I exported from the Pelican panel is a Pelican egg. If you look at the original egg-forge-enhanced.json, the version says "PTDL_v2"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants