Skip to content

Conversation

@max-pfeiffer
Copy link
Contributor

@max-pfeiffer max-pfeiffer commented Mar 19, 2025

I also updated the .gitignore for my Pycharm IDE and virtual environment.

fixes #66

@justinmayer justinmayer changed the title Made _create_absolute_fileurl() function more resilient Make _create_absolute_fileurl() function more resilient Mar 19, 2025
Copy link
Contributor

@justinmayer justinmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix, Max. I reverted the .gitignore changes, which at the very least belong in their own commit and pull request, but in my opinion are better placed on your own workstation inside ~/.gitignore.

@justinmayer justinmayer merged commit acee956 into pelican-plugins:main Mar 19, 2025
7 checks passed
@max-pfeiffer
Copy link
Contributor Author

max-pfeiffer commented Mar 20, 2025

That was actually a very nice contribution experience. Your contribution guide is quite good and enabled me to quickly do that. Thanks a lot for the review and creating a new release right away.

But what you wrote because of .gitignore is not fully plausible to me. The current file already includes exemptions for VSCode files. So we already have a developer specific configuration there. You are discriminating software engineers who live a Microsoft free life here. 😄

Also it's quite common practice to exclude the paths for the most common environment setups there, i.e. https://github.com/github/gitignore/blob/main/Python.gitignore

So what about making the setup a bit more contributor friendly with #75 ?

I will keep working this project a bit more, because I see a couple more issues which need to get fixed. Also robots.txt is lacking the sitemap.

@justinmayer
Copy link
Contributor

Thanks for the kind words about the contribution guide and overall experience.

I am aware that some people repeatedly duplicate the same configuration in every repository's .gitignore, but my personal opinion is that those kinds of general excludes are better suited inside individual developers' ~/.gitignore files, with the repository .gitignore containing primarily repository-specific directives.

My friend Hynek, a well-known Python developer whose opinions I respect, also appears to share my minimalist perspective on this topic: https://github.com/hynek/stamina/blob/main/.gitignore

That said, I merged your follow-up PR given the other existing entries in this particular repository.

@max-pfeiffer
Copy link
Contributor Author

Thanks for elaborating on this a bit more. I will follow up on this as this an approach I am not familiar with.

Maybe it's an idea to add some information about this to your contribution guide.

I just finished the sitemap feature for robots.txt and will send you another MR shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

open_graph.py's _create_absolute_fileurl method does not honor a SITEURL with a subdirectory

2 participants