Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/twelve-nails-occur.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"rrweb-snapshot": patch
---

Prefer the <base href> for resolving inline <style> URLs, falling back to document location if not present.
2 changes: 1 addition & 1 deletion packages/rrweb-snapshot/src/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ export function stringifyStylesheet(s: CSSStyleSheet): string | null {
let sheetHref = s.href;
if (!sheetHref && s.ownerNode && s.ownerNode.ownerDocument) {
// an inline <style> element
sheetHref = s.ownerNode.ownerDocument.location.href;
sheetHref = s.ownerNode.ownerDocument.baseURI;
}
const stringifiedRules = Array.from(rules, (rule: CSSRule) =>
stringifyRule(rule, sheetHref),
Expand Down
50 changes: 50 additions & 0 deletions packages/rrweb-snapshot/test/utils.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import {
replaceChromeGridTemplateAreas,
fixSafariColons,
isNodeMetaEqual,
stringifyStylesheet
} from '../src/utils';
import { NodeType } from '@rrweb/types';
import type { serializedNode, serializedNodeWithId } from '@rrweb/types';
Expand Down Expand Up @@ -374,4 +375,53 @@ describe('utils', () => {
expect(out3).toEqual('[data-aa\\:other] { color: red; }');
});
});

describe('stringifyStylesheet', () => {
it('returns null if rules are missing', () => {
const mockSheet = {
rules: null,
cssRules: null,
} as unknown as CSSStyleSheet;
expect(stringifyStylesheet(mockSheet)).toBeNull();
});

it('stringifies rules using .cssRules if .rules is missing', () => {
const mockRule1 = { cssText: 'div { margin: 0; }' } as CSSRule;
const mockSheet = {
cssRules: [mockRule1],
href: 'https://example.com/main.css',
} as unknown as CSSStyleSheet;
expect(stringifyStylesheet(mockSheet)).toBe('div { margin: 0; }');
});

it('uses ownerNode.ownerDocument.baseURI for inline styles', () => {
const mockFontFaceRule = {
cssText: `
@font-face {
font-family: 'MockFont';
src: url('../fonts/mockfont.woff2') format('woff2');
font-weight: normal;
font-style: normal;
}
`
} as CSSRule;
const mockOwnerDocument = {
location: { href: 'https://example.com/page.html' },
baseURI: 'https://example.com/fonts/',
} as unknown as Document;
const mockOwnerNode = {
ownerDocument: mockOwnerDocument,
} as unknown as Node;
const mockSheet = {
cssRules: [mockFontFaceRule],
href: null,
ownerNode: mockOwnerNode,
} as unknown as CSSStyleSheet;
expect(
stringifyStylesheet(mockSheet)?.replace(/\s+/g, ' ').trim()
).toEqual(
"@font-face { font-family: 'MockFont'; src: url('https://example.com/fonts/mockfont.woff2') format('woff2'); font-weight: normal; font-style: normal; }"
);
});
});
});
Loading