fix: get correct index positions in nested CSS rules for StyleDeclara…#66
Merged
pendo-ops merged 2 commits intopendo-mainfrom Feb 12, 2026
Merged
fix: get correct index positions in nested CSS rules for StyleDeclara…#66pendo-ops merged 2 commits intopendo-mainfrom
pendo-ops merged 2 commits intopendo-mainfrom
Conversation
guntherjh
approved these changes
Feb 6, 2026
arivyiii
approved these changes
Feb 6, 2026
89c26b1 to
da7615a
Compare
|
Failed pendo.io/jira-ref check. Please correct Jira references in the following commits: |
|
[merge] |
|
Branch jc-fix-nested-css-rules deleted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tion events
player would 💥 in the following scenario:
someCSSRule.style.setPropertyis called (this mutation would be a rrweb StyleDeclaration event)using the example above, i call
rule3.style.setProperty('top', '50px')on the site to update the css rule stylewhat happens:
{ ...index: [2], set: { property: 'top', value: '50px'} }instead ofindex: [0, 2](2 is incorrect because it is nested within@media)position.slice(2)was being passed in togetNestedRule. in my example, it would just return an empty arraygetNestedRuleis recursively callingrule.cssRules[position[1]].cssRuleswhich in my example would berule3.cssRules. rule3 is a CSSStyleRule tho so it wouldn't contain anything incssRules