-
Notifications
You must be signed in to change notification settings - Fork 3
[READY] Fix BRL Details Submission #910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging
Are you sure you want to change the base?
[READY] Fix BRL Details Submission #910
Conversation
β Deploy Preview for vortexfi ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
β Deploy Preview for vortex-sandbox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ebma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me overall.
However, there is an issue. When I am on the 'Enter details' page on the widget and click on 'Continue', I get the following error and the page goes blank. Tested for both BRL and EUR onramp.
Uncaught TypeError: Cannot read properties of null (reading 'control')
at RampSubmitButton (RampSubmitButton.tsx:196:23)
RampSubmitButton @ RampSubmitButton.tsx:196
<RampSubmitButton>
SummaryStep @ index.tsx:83
<SummaryStep>
WidgetContent @ index.tsx:65
<WidgetContent>
Widget @ index.tsx:29
<Widget>
Ramp @ index.tsx:15
<Ramp>
Main @ index.tsx:34
<Main>
App @ app.tsx:29
<App>
(anonymous) @ main.tsx:53
|
The CI is failing because of the |
|
@Sharqiewicz could you please resolve the merge conflicts and make sure the CI passes again? |
|
There seems to be a bug, see screenrecording. I cannot proceed with the check out properly. deploy-preview-910.mp4 |
π― Key Changes
π Breaking changes: No
β
π Dependencies: None
βοΈ Configuration: None
β Review Focus Areas