improving input validation for various forms #993
Conversation
✅ Deploy Preview for vortexfi ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for vortex-sandbox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Some issues I still noticed when testing on the deploy preview:
- When on the SELL widget form, I can choose any value that is out of range (below the expected min and above the max) but I never see an error message telling me that it's out of range.
- While we are at it, we might want to reconsider only showing the error messages in the widget form if a wallet is connected. I think that made sense on the landing page, but on the widget page it feels weird. I was entering crazy values and the quote didn't load but I didn't see an error message, just because my wallet was not connected.
- When I confirm a quote on the 'BUY' form and move to the 'Enter details' page, the 'Continue' button is clickable although I didn't enter any CPF or CNPJ yet. When I click on the 'Continue' button while the field is still empty, it triggers the validation and becomes disabled. The respective ticket was asking for the button to be disabled while the form field is empty.
|
Thanks @ebma for testing. Regarding:
What limits do we want in terms of USD? Maybe I'm missing some context sorry, I thought the limit adjustments were for the BUY side only. |
Hmm right, it's not clear in the ticket. I would have assumed that the limits are the same for both directions. |
Closes: #974