Skip to content

Pagination and sorting#409

Merged
davidv1992 merged 3 commits intomainfrom
pagination-and-sorting
Feb 5, 2026
Merged

Pagination and sorting#409
davidv1992 merged 3 commits intomainfrom
pagination-and-sorting

Conversation

@cikzh
Copy link
Member

@cikzh cikzh commented Jan 29, 2026

Adds pagination and sorting for User table and monitor sample list
Also included a bunch of styling changes as advised by Goran
Some of these changes are:

  • bigger font size for main text (section > p)
  • table with borders instead of zebra stripes
  • blackness of text

davidv1992
davidv1992 previously approved these changes Jan 30, 2026
@davidv1992
Copy link
Member

@cikzh this needs a rebase as it has conflicts

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

❌ Patch coverage is 66.24204% with 106 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.84%. Comparing base (5e1d3e1) to head (fd1a56a).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
nts-pool-management/src/models/user.rs 0.00% 29 Missing ⚠️
nts-pool-management/src/models/time_source.rs 0.00% 19 Missing ⚠️
nts-pool-management/src/routes/management.rs 0.00% 19 Missing ⚠️
nts-pool-management/src/routes/admin.rs 0.00% 16 Missing ⚠️
nts-pool-management/src/pagination/params.rs 81.81% 12 Missing ⚠️
nts-pool-management/src/pagination/info.rs 89.52% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #409      +/-   ##
==========================================
- Coverage   71.92%   71.84%   -0.08%     
==========================================
  Files          57       60       +3     
  Lines       13307    13608     +301     
==========================================
+ Hits         9571     9777     +206     
- Misses       3736     3831      +95     
Flag Coverage Δ
beta 72.07% <67.31%> (-0.05%) ⬇️
fuzz 60.79% <ø> (-4.21%) ⬇️
fuzz-client_request 35.35% <ø> (-5.26%) ⬇️
fuzz-key_exchange_response 40.84% <ø> (-0.82%) ⬇️
fuzz-record 35.93% <ø> (ø)
fuzz-server_information_response 24.97% <ø> (-0.47%) ⬇️
msrv 71.74% <66.24%> (-0.10%) ⬇️
stable 72.07% <67.31%> (-0.07%) ⬇️
test 71.78% <66.24%> (-0.07%) ⬇️
x86_64-unknown-linux-gnu 71.78% <66.24%> (-0.07%) ⬇️
x86_64-unknown-linux-musl 72.07% <67.31%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cikzh cikzh force-pushed the pagination-and-sorting branch from cb6c1e4 to fd1a56a Compare February 5, 2026 14:39
@davidv1992 davidv1992 enabled auto-merge February 5, 2026 14:41
@davidv1992 davidv1992 added this pull request to the merge queue Feb 5, 2026
Merged via the queue into main with commit fb872d4 Feb 5, 2026
15 checks passed
@davidv1992 davidv1992 deleted the pagination-and-sorting branch February 5, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants