Skip to content

Comments

Make nts parsing independent of ntp-proto.#5

Merged
davidv1992 merged 3 commits intomainfrom
new-nts-parser
Jun 6, 2025
Merged

Make nts parsing independent of ntp-proto.#5
davidv1992 merged 3 commits intomainfrom
new-nts-parser

Conversation

@davidv1992
Copy link
Member

@davidv1992 davidv1992 commented Jun 5, 2025

This is intended to be a rewrite of the main handling, providing a new starting point for refining the behavior. The old code was a PoC and it shows in the areas touched here, doing some stuff that was questionable.

@codecov
Copy link

codecov bot commented Jun 5, 2025

Codecov Report

Attention: Patch coverage is 83.17089% with 259 lines in your changes missing coverage. Please review.

Project coverage is 67.34%. Comparing base (ea56d4a) to head (6eb5035).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/lib.rs 0.00% 184 Missing ⚠️
src/nts/mod.rs 94.21% 45 Missing ⚠️
src/nts/record.rs 95.34% 26 Missing ⚠️
src/config.rs 78.94% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            main       #5       +/-   ##
==========================================
+ Coverage   7.80%   67.34%   +59.54%     
==========================================
  Files          5        7        +2     
  Lines        628     1969     +1341     
==========================================
+ Hits          49     1326     +1277     
- Misses       579      643       +64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@squell squell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most changes LGTM but I have some remarks wrt. process. Also I really prefer the more detailed comment about connection re-use to be left in.

@davidv1992 davidv1992 requested a review from squell June 6, 2025 11:08
@davidv1992 davidv1992 added this pull request to the merge queue Jun 6, 2025
Merged via the queue into main with commit 46846cf Jun 6, 2025
14 checks passed
@davidv1992 davidv1992 deleted the new-nts-parser branch June 6, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants