Make nts parsing independent of ntp-proto.#5
Merged
davidv1992 merged 3 commits intomainfrom Jun 6, 2025
Merged
Conversation
b1febcf to
a4eca38
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
==========================================
+ Coverage 7.80% 67.34% +59.54%
==========================================
Files 5 7 +2
Lines 628 1969 +1341
==========================================
+ Hits 49 1326 +1277
- Misses 579 643 +64 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
squell
reviewed
Jun 5, 2025
squell
reviewed
Jun 6, 2025
Member
squell
left a comment
There was a problem hiding this comment.
Most changes LGTM but I have some remarks wrt. process. Also I really prefer the more detailed comment about connection re-use to be left in.
a4eca38 to
6eb5035
Compare
squell
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is intended to be a rewrite of the main handling, providing a new starting point for refining the behavior. The old code was a PoC and it shows in the areas touched here, doing some stuff that was questionable.