Fix wrong metric description (copy-past from previous)#618
Merged
davidv1992 merged 1 commit intopendulum-project:mainfrom Feb 27, 2025
Merged
Fix wrong metric description (copy-past from previous)#618davidv1992 merged 1 commit intopendulum-project:mainfrom
davidv1992 merged 1 commit intopendulum-project:mainfrom
Conversation
davidv1992
approved these changes
Feb 27, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #618 +/- ##
=======================================
Coverage 61.58% 61.58%
=======================================
Files 62 62
Lines 8415 8415
=======================================
Hits 5182 5182
Misses 3233 3233 ☔ View full report in Codecov by Sentry. |
149593a to
adbb8dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently, the description of
time_sourceas been copied fromptp_timescale, the metric one above. I tried to come up with a meaningful description based on Section 8.2.4.9 of the IEEE Std 1588-2019. Feel free to adopt it if necessary.