funding: implement execute ActionLiquidityTournamentVote#5033
Merged
cronokirby merged 4 commits intoprotocol/lqt_branchfrom Jan 31, 2025
Merged
funding: implement execute ActionLiquidityTournamentVote#5033cronokirby merged 4 commits intoprotocol/lqt_branchfrom
ActionLiquidityTournamentVote#5033cronokirby merged 4 commits intoprotocol/lqt_branchfrom
Conversation
cronokirby
force-pushed
the
cronokirby/5032-tally
branch
from
472487a to
f57279b
Compare
cronokirby
force-pushed
the
cronokirby/5032-tally
branch
from
f57279b to
a97a3f0
Compare
cronokirby
added
the
consensus-breaking
cronokirby
force-pushed
the
cronokirby/5032-tally
branch
from
a97a3f0 to
67a22f7
Compare
2 tasks
cronokirby
force-pushed
the
cronokirby/5032-tally
branch
from
67a22f7 to
2e5faad
Compare
cronokirby
force-pushed
the
cronokirby/5032-tally
branch
from
2e5faad to
6097a52
Compare
erwanor
reviewed
Jan 31, 2025
| self.body.nullifier, | ||
| current_epoch.index | ||
| ); | ||
| state.put_lqt_spent_nullifier(current_epoch.index, nullifier, TransactionId([0u8; 32])); |
Contributor
There was a problem hiding this comment.
Yeah I think we can revisit in a follow-up PR.
erwanor
reviewed
Jan 31, 2025
| bytes_asset.copy_from_slice(&asset.to_bytes()); | ||
| bytes_power.copy_from_slice(&((!power).to_be_bytes())); | ||
| bytes_voter.copy_from_slice(&voter.to_vec()); | ||
|
|
erwanor
reviewed
Jan 31, 2025
| /// This will return None if the denom is not a base denom. | ||
| pub fn incentivized_id(&self) -> Option<asset::Id> { | ||
| REGISTRY | ||
| .parse_denom(&self.incentivized.denom) |
Contributor
There was a problem hiding this comment.
I presume this still work for unknown denoms right?
Contributor
Author
There was a problem hiding this comment.
https://rustdoc.penumbra.zone/main/src/penumbra_sdk_asset/asset/registry.rs.html#70
Yeah, the case in which it returns None is only when it's a known non-base denom.
erwanor
approved these changes
Jan 31, 2025
Contributor
erwanor
left a comment
erwanor
left a comment
There was a problem hiding this comment.
ACK writing a zero-ed TxId in the NF set is fine, we can follow up with another PR
erwanor
changed the title
ActionLiquidityTournamentVote
conorsch
pushed a commit
that referenced
this pull request
Jan 31, 2025
Closes #5032. The check and execute logic for the action handler is still missing the nullifier check, but there's an obvious insertion point for adding that logic. Testing deferred.
conorsch
pushed a commit
that referenced
this pull request
Feb 4, 2025
Closes #5032. The check and execute logic for the action handler is still missing the nullifier check, but there's an obvious insertion point for adding that logic. Testing deferred.
conorsch
pushed a commit
that referenced
this pull request
Feb 5, 2025
Closes #5032. The check and execute logic for the action handler is still missing the nullifier check, but there's an obvious insertion point for adding that logic. Testing deferred.
conorsch
pushed a commit
that referenced
this pull request
Feb 5, 2025
Closes #5032. The check and execute logic for the action handler is still missing the nullifier check, but there's an obvious insertion point for adding that logic. Testing deferred.
conorsch
pushed a commit
that referenced
this pull request
Feb 14, 2025
Closes #5032. The check and execute logic for the action handler is still missing the nullifier check, but there's an obvious insertion point for adding that logic. Testing deferred.
conorsch
pushed a commit
that referenced
this pull request
Feb 21, 2025
Closes #5032. The check and execute logic for the action handler is still missing the nullifier check, but there's an obvious insertion point for adding that logic. Testing deferred.
cronokirby
added a commit
that referenced
this pull request
Feb 27, 2025
Closes #5032. The check and execute logic for the action handler is still missing the nullifier check, but there's an obvious insertion point for adding that logic. Testing deferred.
conorsch
pushed a commit
that referenced
this pull request
Mar 18, 2025
Closes #5032. The check and execute logic for the action handler is still missing the nullifier check, but there's an obvious insertion point for adding that logic. Testing deferred.
conorsch
pushed a commit
that referenced
this pull request
Mar 24, 2025
Closes #5032. The check and execute logic for the action handler is still missing the nullifier check, but there's an obvious insertion point for adding that logic. Testing deferred.
cronokirby
added a commit
that referenced
this pull request
Mar 28, 2025
Closes #5032. The check and execute logic for the action handler is still missing the nullifier check, but there's an obvious insertion point for adding that logic. Testing deferred.
cronokirby
added a commit
that referenced
this pull request
Apr 10, 2025
Closes #5032. The check and execute logic for the action handler is still missing the nullifier check, but there's an obvious insertion point for adding that logic. Testing deferred.
cronokirby
added a commit
that referenced
this pull request
Apr 11, 2025
Closes #5032. The check and execute logic for the action handler is still missing the nullifier check, but there's an obvious insertion point for adding that logic. Testing deferred.
cronokirby
added a commit
that referenced
this pull request
Apr 14, 2025
Closes #5032. The check and execute logic for the action handler is still missing the nullifier check, but there's an obvious insertion point for adding that logic. Testing deferred.
cronokirby
added a commit
that referenced
this pull request
Apr 14, 2025
Closes #5032. The check and execute logic for the action handler is still missing the nullifier check, but there's an obvious insertion point for adding that logic. Testing deferred.
conorsch
pushed a commit
that referenced
this pull request
Apr 30, 2025
Closes #5032. The check and execute logic for the action handler is still missing the nullifier check, but there's an obvious insertion point for adding that logic. Testing deferred.
conorsch
pushed a commit
that referenced
this pull request
Apr 30, 2025
Closes #5032. The check and execute logic for the action handler is still missing the nullifier check, but there's an obvious insertion point for adding that logic. Testing deferred.
conorsch
pushed a commit
that referenced
this pull request
May 21, 2025
Closes #5032. The check and execute logic for the action handler is still missing the nullifier check, but there's an obvious insertion point for adding that logic. Testing deferred.
conorsch
pushed a commit
that referenced
this pull request
Jun 12, 2025
Closes #5032. The check and execute logic for the action handler is still missing the nullifier check, but there's an obvious insertion point for adding that logic. Testing deferred.
conorsch
pushed a commit
that referenced
this pull request
Jun 13, 2025
Closes #5032. The check and execute logic for the action handler is still missing the nullifier check, but there's an obvious insertion point for adding that logic. Testing deferred.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5032.
The check and execute logic for the action handler is still missing the nullifier check, but there's an obvious insertion point for adding that logic.
Testing deferred.