Skip to content

Backport AppParameter event fix from 1.5.1 to v0.80.x #5189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
conorsch merged 2 commits into from
May 1, 2025
Merged

Backport AppParameter event fix from 1.5.1 to v0.80.x #5189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
259aa6c
Make EventAppParametersChange public
cronokirby Apr 30, 2025
d085c19
Emit EventAppParametersChange
cronokirby Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions crates/core/app/src/app/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ use std::time::Duration;
use anyhow::{Context, Result};
use async_trait::async_trait;
use cnidarium::{ArcStateDeltaExt, Snapshot, StateDelta, StateRead, StateWrite, Storage};
use cnidarium_component::Component;
use cnidarium_component::Component as _;
use ibc_types::core::connection::ChainId;
use jmt::RootHash;
use penumbra_auction::component::{Auction, StateReadExt as _, StateWriteExt as _};
Expand All @@ -22,7 +22,7 @@ use penumbra_governance::component::{Governance, StateReadExt as _, StateWriteEx
use penumbra_ibc::component::{Ibc, StateWriteExt as _};
use penumbra_ibc::StateReadExt as _;
use penumbra_proto::core::app::v1::TransactionsByHeightResponse;
use penumbra_proto::DomainType;
use penumbra_proto::{DomainType, StateWriteProto as _};
use penumbra_sct::component::clock::EpochRead;
use penumbra_sct::component::sct::Sct;
use penumbra_sct::component::{StateReadExt as _, StateWriteExt as _};
Expand All @@ -41,6 +41,7 @@ use tokio::time::sleep;
use tracing::{instrument, Instrument};

use crate::action_handler::AppActionHandler;
use crate::event::EventAppParametersChange;
use crate::genesis::AppState;
use crate::params::change::ParameterChangeExt as _;
use crate::params::AppParameters;
Expand Down Expand Up @@ -320,7 +321,13 @@ impl App {
match change.apply_changes(old_params) {
Ok(new_params) => {
tracing::info!(?change, "applied app parameter change");
state_tx.put_app_params(new_params);
state_tx.put_app_params(new_params.clone());
state_tx.record_proto(
EventAppParametersChange {
new_parameters: new_params,
}
.to_proto(),
)
}
Err(e) => {
// N.B. this is an "info" rather than "warn" because it does not report
Expand Down
4 changes: 2 additions & 2 deletions crates/core/app/src/event.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ use prost::Name as _;
use crate::params::AppParameters;

#[derive(Clone, Debug)]
struct EventAppParametersChange {
new_parameters: AppParameters,
pub struct EventAppParametersChange {
pub new_parameters: AppParameters,
}

impl TryFrom<pb::EventAppParametersChange> for EventAppParametersChange {
Expand Down
Loading