dialogはexportだけでなくstyleのmixinでもkeyframesを適用する#88
Merged
Conversation
nio-nio-nio
approved these changes
Dec 11, 2025
Contributor
nio-nio-nio
left a comment
nio-nio-nio
left a comment
There was a problem hiding this comment.
良さそうでした！ご対応ありがとうございます！
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
inhouse/dialogでは、
@keyframesによるアニメーションの設定を@mixin exportで適用していますが、@mixin dialog-styleの方には適用できていなかったのでstyleの方にも適用して、classベース・mixinベースのスタイリング両方ともアニメーションをともなったdialogの開閉に対応させました。