Open
Conversation
code is ... hard to follow, so -g is rather useful. No need for weird makefile rules, just set CFLAGS.
This "default" detect routine should be the most forgiving, but this check rejects my board. If you want contributions from likely compatible devices, running the binary against a dump file should provide best effort decoding, not simply, "not detected" and then exit. Removing this check generates what appears to be a very useful and valid dump.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to just file an issue, really, but pulls are the only way :)
given the structure of the code, I needed -g to step through this and work out why it produced no output.
Just because the board isn't a known version, it should still attempt to decode the output, surely?!
I suggest that if values of a layout are all 0xff, that it should be considered invalid. A dump from my carambola2 module art partition is available at: http://paste.fedoraproject.org/253373/39205928/ for a while at least. (note that the second partition is all 0xfffff)