added the option to capture stderr into the output file

composer.json

@@ -17,7 +17,7 @@
     ],
     "minimum-stability": "dev",
     "require": {
-        "php": "^7.1",
+        "php": "^7.2",
         "dragonmantank/cron-expression": "^2.3"
     },
     "require-dev": {

src/GO/Job.php

@@ -143,6 +143,11 @@ class Job
      */
     private $outputMode;
 
+    /**
+     * @var bool
+     */
+    private $captureStdErr = false;
+
     /**
      * Create a new Job instance.
      *
@@ -215,8 +220,8 @@ public function isDue(DateTime $date = null)
     public function isOverlapping()
     {
         return $this->lockFile &&
-               file_exists($this->lockFile) &&
-               call_user_func($this->whenOverlapping, filemtime($this->lockFile)) === false;
+            file_exists($this->lockFile) &&
+            call_user_func($this->whenOverlapping, filemtime($this->lockFile)) === false;
     }
 
     /**
@@ -299,27 +304,34 @@ public function compile()
             }
         }
 
-        // Add the boilerplate to redirect the output to file/s
+        // Handle output redirection for different platforms
         if (count($this->outputTo) > 0) {
-            $compiled .= ' | tee ';
-            $compiled .= $this->outputMode === 'a' ? '-a ' : '';
-            foreach ($this->outputTo as $file) {
-                $compiled .= $file . ' ';
+            if ($this->captureStdErr) {
+                $compiled .= ' 2>&1';
             }
 
-            $compiled = trim($compiled);
+            foreach ($this->outputTo as $file) {
+                $compiled .= ' >> ' . escapeshellarg($file);
+            }
         }
 
-        // Add boilerplate to remove lockfile after execution
+        // Handle lock file removal
         if ($this->lockFile) {
-            $compiled .= '; rm ' . $this->lockFile;
+            $lockFile = escapeshellarg($this->lockFile);
+            if (PHP_OS_FAMILY === 'Windows') {
+                $compiled .= " && del $lockFile";
+            } else {
+                $compiled .= " && rm $lockFile";
+            }
         }
 
-        // Add boilerplate to run in background
+        // Background execution
         if ($this->canRunInBackground()) {
-            // Parentheses are need execute the chain of commands in a subshell
-            // that can then run in background
-            $compiled = '(' . $compiled . ') > /dev/null 2>&1 &';
+            if (PHP_OS_FAMILY === 'Windows') {
+                $compiled = 'start /B ' . $compiled;
+            } else {
+                $compiled .= ' &';
+            }
         }
 
         return trim($compiled);
@@ -477,6 +489,19 @@ public function output($filename, $append = false)
         return $this;
     }
 
+    /**
+     * Set the option for writing stderr to the output file.
+     *
+     * @param bool $capture
+     * @return self
+     */
+    public function captureStandardError($capture = true)
+    {
+        $this->captureStdErr = $capture;
+
+        return $this;
+    }
+
     /**
      * Get the job output.
      *

tests/GO/JobOutputFilesTest.php

@@ -198,4 +198,47 @@ public function testShouldWriteFunctionOutputAndReturnToFile()
 
         unlink($outputFile);
     }
+
+    public function testShouldWriteStdErrToFile()
+    {
+        $command = PHP_BINARY . ' ' . __DIR__ . '/../error_job.php';
+        $job = new Job($command);
+        $outputFile = __DIR__ . '/../tmp/output.log';
+
+        @unlink($outputFile);
+
+        // Test fist that the file doesn't exist yet
+        $this->assertFalse(file_exists($outputFile));
+        $job->captureStandardError();
+        $job->output($outputFile)->run();
+
+        sleep(2);
+        $this->assertTrue(file_exists($outputFile));
+
+        // Content should be the error for calling an undefined function
+        $this->assertStringStartsWith('PHP Fatal error:', file_get_contents($outputFile));
+
+        unlink($outputFile);
+    }
+
+    public function testShouldNotWriteStdErrToFile()
+    {
+        $command = PHP_BINARY . ' ' . __DIR__ . '/../error_job.php';
+        $job = new Job($command);
+        $outputFile = __DIR__ . '/../tmp/output.log';
+
+        @unlink($outputFile);
+
+        // Test fist that the file doesn't exist yet
+        $this->assertFalse(file_exists($outputFile));
+        $job->output($outputFile)->run();
+
+        sleep(2);
+        $this->assertTrue(file_exists($outputFile));
+
+        // Content should be ''
+        $this->assertEquals('', file_get_contents($outputFile));
+
+        unlink($outputFile);
+    }
 }

tests/error_job.php

@@ -0,0 +1,3 @@
+<?php
+
+call_a_function_that_does_not_exist();