PMM-7 logrus to slog #1062
Merged
PMM-7 logrus to slog #1062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.62.0 to 0.63.0. - [Release notes](https://github.com/prometheus/common/releases) - [Changelog](https://github.com/prometheus/common/blob/main/RELEASE.md) - [Commits](prometheus/common@v0.62.0...v0.63.0) --- updated-dependencies: - dependency-name: github.com/prometheus/common dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
….0' into PMM-7-logrus-to-slog
idoqo
requested review from
BupycHuk and
JiriCtvrtka
and removed request for
a team
Member
|
please address linter issues |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
BupycHuk
approved these changes
Apr 14, 2025
There was a problem hiding this comment.
Copilot reviewed 46 out of 46 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
exporter/indexstats_collector.go:72
- [nitpick] For consistency and to preserve error context, consider passing the error value directly (i.e. 'err') rather than using err.Error() in the key/value pairs.
logger.Error("cannot auto discover databases and collections", "error", err.Error())
exporter/currentop_collector.go:105
- [nitpick] Instead of using fmt.Sprintf to format the error message, consider using structured logging to include the type information (e.g., logger.Error("Invalid type assertion for inprog", "actualType", fmt.Sprintf("%T", r["inprog"]))) for improved clarity.
logger.Error(fmt.Sprintf("Invalid type primitive.A assertion for 'inprog': %T", r["inprog"]))
JiriCtvrtka
approved these changes
Apr 24, 2025
ademidoff
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below we provide a basic checklist of things that would make it a good PR:
Once all checks pass and the code is ready for review, please add
pmm-review-exportersteam as the reviewer. That would assign people from the review team automatically. Report any issues on our Forum.