Skip to content

PMM-14141: Respect Prometheus scrape-timeout header #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
idoqo merged 4 commits into from
Jul 21, 2025
Merged

PMM-14141: Respect Prometheus scrape-timeout header #1107

idoqo merged 4 commits into from
Jul 21, 2025

Conversation

@impimp
Copy link
Contributor

@impimp impimp commented Jul 3, 2025 •
edited by atlassian bot
Loading

@impimp impimp requested a review from a team as a code owner July 3, 2025 19:19
@impimp impimp requested review from BupycHuk and JiriCtvrtka and removed request for a team July 3, 2025 19:19
@it-percona-cla
Copy link

it-percona-cla commented Jul 3, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jul 3, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 47.05882% with 9 lines in your changes missing coverage. Please review.

Project coverage is 65.29%. Comparing base (dc46ed5) to head (8143e34).
Report is 112 commits behind head on main.

Files with missing lines Patch % Lines
exporter/exporter.go 47.05% 7 Missing and 2 partials ⚠️

❗ There is a different number of reports uploaded between BASE (dc46ed5) and HEAD (8143e34). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (dc46ed5) HEAD (8143e34)
agent 10 7
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1107      +/-   ##
==========================================
- Coverage   70.88%   65.29%   -5.60%     
==========================================
  Files          28       29       +1     
  Lines        3569     3080     -489     
==========================================
- Hits         2530     2011     -519     
- Misses        904      929      +25     
- Partials      135      140       +5
Flag Coverage Δ
agent 65.29% <47.05%> (-5.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BupycHuk
Copy link
Member

BupycHuk commented Jul 3, 2025

Hi, can you please address linter comments?

impimp added 2 commits July 4, 2025 08:50
@impimp
Fix parsing of X-Prometheus-Scrape-Timeout-Seconds header
de793b8 
The previous implementation expected this header to be an integer, but vmagent
 may send it as a float. This caused incorrect handling in `mongodb_exporter`.

Updated to support float values.
@impimp
Avoid stale connections by pinging on acquire
d15be68 
The exporter was returning cached MongoDB connections without validating their health. This meant that if a connection had become unhealthy,
subsequent operations would fail after a delay (serverSelectionTimeout etc), causing the entire request to be slower than it should be.

This commit adds  `Ping` check before returning a cached client.
@impimp
Copy link
Contributor Author

impimp commented Jul 4, 2025

Hi, can you please address linter comments?

Done.

ademidoff
ademidoff reviewed Jul 7, 2025
View reviewed changes
@impimp @ademidoff
Update exporter/exporter.go
ee2070b 
Co-authored-by: Alex Demidoff <[email protected]>
@BupycHuk BupycHuk requested a review from Copilot July 7, 2025 09:10
Copilot AI reviewed Jul 7, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the MongoDB client reconnection logic and refines the Prometheus scrape timeout parsing in the HTTP handler.

  • Adds a Ping check before reusing an existing MongoDB client in getClient.
  • Switches timeout header parsing from Atoi to ParseFloat and logs invalid values.
  • Updates the WithTimeout calculation to work with floating‐point seconds and subtracts the configured offset.
Comments suppressed due to low confidence (1)

exporter/exporter.go:309

  • [nitpick] The variable name seconds is generic. Renaming it to timeoutSeconds or similar would improve clarity.
		seconds := 10.0

@impimp impimp requested a review from ademidoff July 8, 2025 06:50
@idoqo idoqo changed the title PMM-14141 PMM-14141: Respect Prometheus scrape-timeout header Jul 15, 2025
@idoqo idoqo mentioned this pull request Jul 15, 2025
Merged
@idoqo idoqo mentioned this pull request Jul 15, 2025
Closed
2 tasks
@idoqo idoqo merged commit f774e70 into percona:main Jul 21, 2025
13 of 15 checks passed
@impimp impimp deleted the PMM-14141 branch July 21, 2025 05:18
@impimp impimp restored the PMM-14141 branch July 21, 2025 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@idoqo idoqo idoqo approved these changes

@JiriCtvrtka JiriCtvrtka JiriCtvrtka approved these changes

@BupycHuk BupycHuk Awaiting requested review from BupycHuk BupycHuk is a code owner automatically assigned from percona/pmm-review-exporters

@ademidoff ademidoff Awaiting requested review from ademidoff

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@impimp @it-percona-cla @BupycHuk @ademidoff @idoqo @JiriCtvrtka