Fix timeseries collections being ignored in discovery mode #1112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The filter excluding view collections erronously also dropped collections with type "timeseries"
najder-k
requested review from
BupycHuk and
JiriCtvrtka
and removed request for
a team
JiriCtvrtka
approved these changes
Jul 23, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1112 +/- ##
==========================================
- Coverage 70.88% 65.31% -5.58%
==========================================
Files 28 29 +1
Lines 3569 3082 -487
==========================================
- Hits 2530 2013 -517
- Misses 904 929 +25
- Partials 135 140 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
idoqo
approved these changes
Jul 23, 2025
BupycHuk
approved these changes
Aug 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filter excluding view collections erronously also dropped collections with type "timeseries". This caused metrics from timeseries collections to not be collected (including basic ones, like mongotop and index accesses).