Fix metrics mongodb_connPoolStats_replicaSets_{replName})_key1_key12 collect failed #1130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame/configReplSetName}_{childKey}_{grandChildKey} raise error with '...was collected before with the same name and label values...'
naughtyGitCat
requested review from
BupycHuk and
JiriCtvrtka
and removed request for
a team
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1130 +/- ##
==========================================
- Coverage 70.88% 65.04% -5.85%
==========================================
Files 28 29 +1
Lines 3569 3095 -474
==========================================
- Hits 2530 2013 -517
- Misses 904 941 +37
- Partials 135 141 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
naughtyGitCat
changed the title
BupycHuk
approved these changes
Aug 5, 2025
BupycHuk
reviewed
Aug 5, 2025
| @@ -401,6 +401,9 @@ func processSlice(prefix string, v []interface{}, commonLabels map[string]string | |||
| if host, ok := s["host"].(string); ok { | |||
| labels["member_idx"] = host | |||
| } | |||
| if addr, ok := s["addr"].(string); ok { | |||
| labels["member_addr"] = addr | |||
There was a problem hiding this comment.
wouldn't it be better to reuse member_idx?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below we provide a basic checklist of things that would make it a good PR:
Once all checks pass and the code is ready for review, please add
pmm-review-exportersteam as the reviewer. That would assign people from the review team automatically. Report any issues on our Forum.