PMM-14404 - Enhance PBM backup metrics collection by including cluste… #1181
+52
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r node information - Added retrieval of current node role and cluster status. - Updated metrics to include node-specific details such as role and host for each backup. - Improved error handling for node info and cluster status retrieval.
theTibi
requested review from
BupycHuk and
JiriCtvrtka
and removed request for
a team
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1181 +/- ##
==========================================
- Coverage 70.88% 65.09% -5.80%
==========================================
Files 28 29 +1
Lines 3569 3100 -469
==========================================
- Hits 2530 2018 -512
- Misses 904 941 +37
- Partials 135 141 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… retrieval - Removed unnecessary cluster status retrieval and integrated replset iteration directly from backup metadata. - Updated metrics to focus on node-specific details, enhancing clarity and performance. - Improved overall structure for better maintainability.
BupycHuk
reviewed
Oct 15, 2025
…ved metric creation - Added logging for the creation of metrics and labels to provide better visibility during the backup metrics collection process. - Updated the `createPBMMetric` function to include logging of the metric name being created. - Enhanced the iteration over backups and replsets with detailed logs for each processing step, including current node checks and metric additions. - Improved overall structure for clarity and maintainability.
…nd improved metric creation" This reverts commit 5642f84.
- Updated `pbmBackupsMetrics` and `pbmAgentMetrics` functions to accept `currentNode` as a parameter, reducing redundant calls to retrieve node information. - Enhanced error handling for node info retrieval, ensuring metrics are only collected if the current node information is successfully obtained. - Improved overall structure for clarity and maintainability.
BupycHuk
approved these changes
Oct 16, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r node information
PMM-XXXX (optional, if ticket reported)
Below we provide a basic checklist of things that would make it a good PR:
Once all checks pass and the code is ready for review, please add
pmm-review-exportersteam as the reviewer. That would assign people from the review team automatically. Report any issues on our Forum.