Skip to content

Conversation

@idoqo
Copy link
Contributor

@idoqo idoqo commented Oct 23, 2024

PMM-13426

  • Links to related pull requests (optional).

Below we provide a basic checklist of things that would make it a good PR:

  • Make sure to sign the CLA (Contributor License Agreement).
  • Make sure all tests pass.
  • Keep current with the target branch and fix conflicts if necessary.
  • Update jira ticket description if necessary.
  • Attach screenshots and/or console output to the jira ticket to confirm new behavior, if applicable.
  • Leave notes to the reviewers if you need to focus their attention on something specific.

Once all checks pass and the code is ready for review, please add pmm-review-exporters team as the reviewer. That would assign people from the review team automatically. Report any issues on our Forum.

@idoqo idoqo requested a review from a team as a code owner October 23, 2024 08:36
@idoqo idoqo requested review from BupycHuk and JiriCtvrtka and removed request for a team October 23, 2024 08:36
@it-percona-cla
Copy link

it-percona-cla commented Oct 23, 2024

CLA assistant check
All committers have signed the CLA.

@idoqo idoqo merged commit dac67a8 into main Oct 25, 2024
7 checks passed
@idoqo idoqo deleted the update-pbm-sdk branch October 25, 2024 07:46
BupycHuk pushed a commit that referenced this pull request Oct 25, 2024
(cherry picked from commit dac67a8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants