Skip to content

Conversation

@BupycHuk
Copy link
Member

@BupycHuk BupycHuk commented Nov 8, 2024

PMM-9870 (optional, if ticket reported)


Below we provide a basic checklist of things that would make it a good PR:

  • Make sure to sign the CLA (Contributor License Agreement).
  • Make sure all tests pass.
  • Keep current with the target branch and fix conflicts if necessary.
  • Update jira ticket description if necessary.
  • Attach screenshots and/or console output to the jira ticket to confirm new behavior, if applicable.
  • Leave notes to the reviewers if you need to focus their attention on something specific.

Once all checks pass and the code is ready for review, please add pmm-review-exporters team as the reviewer. That would assign people from the review team automatically. Report any issues on our Forum.

@BupycHuk BupycHuk requested a review from a team as a code owner November 8, 2024 18:09
@BupycHuk BupycHuk requested review from JiriCtvrtka and ademidoff and removed request for a team November 8, 2024 18:09
@BupycHuk BupycHuk enabled auto-merge (squash) November 14, 2024 12:23
@BupycHuk BupycHuk disabled auto-merge November 14, 2024 12:23
@BupycHuk BupycHuk merged commit 489091c into main Nov 14, 2024
14 checks passed
@BupycHuk BupycHuk deleted the PMM-9870-fix-collstats-indexsizes-metrics branch November 14, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants