Skip to content

PMM-14440: avoid default gatherer when standard collectors are enabled #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: v3
Choose a base branch
from
Open

PMM-14440: avoid default gatherer when standard collectors are enabled #333

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d23f6b
avoid default gatherer when standard collectors are enabled
idoqo Nov 19, 2025
74932ce
fix typo
idoqo Nov 20, 2025
ea063a7
Merge branch 'v3' into PMM-14440-duplicate-metrics
ademidoff Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions mysqld_exporter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,9 +263,21 @@ func newHandler(scrapers []collector.Scraper, logger *slog.Logger) http.HandlerF
registry := prometheus.NewRegistry()
registry.MustRegister(collector.New(ctx, dsn, filteredScrapers, logger))

gatherers := prometheus.Gatherers{
prometheus.DefaultGatherer,
registry,
useDefaultGatherer := true
for _, scraper := range filteredScrapers {
name := scraper.Name()
if name == "standard.go" || name == "standard.process" {
// these scrapers already exposes runtime/process metrics, so we disable the default gatherer to avoid duplicates
useDefaultGatherer = false
break
}
}

var gatherers prometheus.Gatherers
if useDefaultGatherer {
gatherers = prometheus.Gatherers{prometheus.DefaultGatherer, registry}
} else {
gatherers = prometheus.Gatherers{registry}
}

eLogger := &errLogger{logger: logger}
Expand Down
Loading