fix(deps): remove replace directive for github.com/openark/golib #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of DISTMYSQL-157 the github.com/openark/golib module was forked into a go/golib subdirectory of orchestrator and used via a top-level replace directive with a dummy go.mod under go/golib/go.mod. With orchestrator now forked away from openark it is cleaner to just update the import paths and use the in-tree packages directly rather than via a replace directive. Signed-off-by: Dominic Evans <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of DISTMYSQL-157 the github.com/openark/golib module was forked into a go/golib subdirectory of orchestrator and used via a top-level replace directive with a dummy go.mod under go/golib/go.mod. With orchestrator now forked away from openark it is cleaner to just update the import paths and use the in-tree packages directly rather than via a replace directive.