Skip to content

Comments

PCSM-253: Remove unused config options#179

Merged
chupe merged 1 commit intomainfrom
pcsm-253
Feb 10, 2026
Merged

PCSM-253: Remove unused config options#179
chupe merged 1 commit intomainfrom
pcsm-253

Conversation

@chupe
Copy link
Collaborator

@chupe chupe commented Jan 27, 2026

PCSM-253

Main Work (PCSM-253 - Config Cleanup):
Removed deprecated/unused configuration options identified during the PCSM-219 review:

  • Removed --ignore-history-lost flag (no documented use case, internal-only concern)
  • Cleaned up unused finalizeRequest struct and simplified Finalize API

@chupe chupe marked this pull request as ready for review January 27, 2026 23:15
@chupe chupe requested a review from inelpandzic as a code owner January 27, 2026 23:15
@igroene
Copy link
Member

igroene commented Feb 4, 2026

for the history lost error I agree we can remove that, as we cannot really resume replication and be consistentif events are lost... we should error out instead.
For bulk write, I am concerned we might run into issues or lower performance since client-side bulk is a new feature.... it doesn't hurt to have options available so I would keep that option configurable.

@chupe chupe merged commit 98fbf31 into main Feb 10, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants