K8SPG-651 - Update PG charts for 2.6.0 release#459
Merged
jvpasinatto merged 23 commits intomainfrom Mar 17, 2025
Merged
Conversation
K8SPG-699: Add example for pgvector
https://perconadev.atlassian.net/browse/K8SPG-554 Co-authored-by: Julio Pasinatto <julio.pasinatto@percona.com>
* Add autoCreateUserSchema field. * Add autoCreateUserSchema field in pg-db template --------- Co-authored-by: Julio Pasinatto <julio.pasinatto@percona.com>
|
Any news for this PR ? We forked this repository because of this missing keys today |
|
+1 |
Contributor
Author
|
Hello @CorentinRegnier, Are you interested in a specific change being made in this PR? |
…s` (#462) * K8SPG-619: add `restartPolicy` and `backoffLimit` to `.pgbackrest.jobs` https://perconadev.atlassian.net/browse/K8SPG-619 * update README --------- Co-authored-by: Julio Pasinatto <julio.pasinatto@percona.com>
💡 Enhancement Proposal: Add Resource Requests for ContainersHi @jvpasinatto 👋, I noticed that some containers in the solution do not currently handle the 📌 Changes Introduced:
This will help improve resource allocation and workload stability 🚀. 🔍 Diff of the Changes:diff --git a/charts/pg-db/templates/official_cluster_pg_db_2_5_3.yaml b/charts/pg-db/templates/cluster.yaml
+++ b/charts/pg-db/templates/cluster.yaml
@@ -200,6 +200,11 @@ spec:
replicaCertCopy:
{{- if $instance.containers.replicaCertCopy.resources }}
resources:
+ {{- if $instance.containers.replicaCertCopy.resources.requests }}
+ requests:
+ cpu: {{ $instance.containers.replicaCertCopy.resources.requests.cpu }}
+ memory: {{ $instance.containers.replicaCertCopy.resources.requests.memory }}
+ {{- end }}
{{- if $instance.containers.replicaCertCopy.resources.limits }}
limits:
cpu: {{ $instance.containers.replicaCertCopy.resources.limits.cpu }}
@@ -300,6 +305,11 @@ spec:
pgbouncerConfig:
{{- if .Values.proxy.pgBouncer.containers.pgbouncerConfig.resources }}
resources:
+ {{- if .Values.proxy.pgBouncer.containers.pgbouncerConfig.resources.requests }}
+ requests:
+ cpu: {{ .Values.proxy.pgBouncer.containers.pgbouncerConfig.resources.requests.cpu }}
+ memory: {{ .Values.proxy.pgBouncer.containers.pgbouncerConfig.resources.requests.memory }}
+ {{- end }}
{{- if .Values.proxy.pgBouncer.containers.pgbouncerConfig.resources.limits }}
limits:
cpu: {{ .Values.proxy.pgBouncer.containers.pgbouncerConfig.resources.limits.cpu }}
@@ -386,6 +396,11 @@ spec:
pgbackrest:
{{- if .Values.backups.pgbackrest.containers.pgbackrest.resources }}
resources:
+ {{- if .Values.backups.pgbackrest.containers.pgbackrest.resources.requests }}
+ requests:
+ cpu: {{ .Values.backups.pgbackrest.containers.pgbackrest.resources.requests.cpu }}
+ memory: {{ .Values.backups.pgbackrest.containers.pgbackrest.resources.requests.memory }}
+ {{- end }}
{{- if .Values.backups.pgbackrest.containers.pgbackrest.resources.limits }}
limits:
cpu: {{ .Values.backups.pgbackrest.containers.pgbackrest.resources.limits.cpu }}
@@ -397,6 +412,11 @@ spec:
pgbackrestConfig:
{{- if .Values.backups.pgbackrest.containers.pgbackrestConfig.resources }}
resources:
+ {{- if .Values.backups.pgbackrest.containers.pgbackrestConfig.resources.requests }}
+ requests:
+ cpu: {{ .Values.backups.pgbackrest.containers.pgbackrestConfig.resources.requests.cpu }}
+ memory: {{ .Values.backups.pgbackrest.containers.pgbackrestConfig.resources.requests.memory }}
+ {{- end }}
{{- if .Values.backups.pgbackrest.containers.pgbackrestConfig.resources.limits }}
limits:
cpu: {{ .Values.backups.pgbackrest.containers.pgbackrestConfig.resources.limits.cpu }}
@@ -408,10 +428,19 @@ spec:
{{- if .Values.backups.pgbackrest.jobs }}
jobs:
priorityClassName: {{ .Values.backups.pgbackrest.jobs.priorityClassName }}
+ {{- if .Values.backups.pgbackrest.jobs.resources }}
resources:
+ {{- if .Values.backups.pgbackrest.jobs.resources.requests }}
+ requests:
+ cpu: {{ .Values.backups.pgbackrest.jobs.resources.requests.cpu }}
+ memory: {{ .Values.backups.pgbackrest.jobs.resources.requests.memory }}
+ {{- end}}
+ {{- if .Values.backups.pgbackrest.jobs.resources.limits }}
limits:
cpu: {{ .Values.backups.pgbackrest.jobs.resources.limits.cpu }}
memory: {{ .Values.backups.pgbackrest.jobs.resources.limits.memory }}
+ {{- end}}
+ {{- end}}
{{- if .Values.backups.pgbackrest.jobs.tolerations }}
tolerations:
{{ .Values.backups.pgbackrest.jobs.tolerations | toYaml | indent 10 }}
@@ -427,6 +456,19 @@ spec:
{{- end }}
{{- if .Values.backups.pgbackrest.repoHost }}
repoHost:
+ {{- if .Values.backups.pgbackrest.repoHost.resources }}
+ resources:
+ {{- if .Values.backups.pgbackrest.repoHost.resources.requests }}
+ requests:
+ cpu: {{ .Values.backups.pgbackrest.repoHost.resources.requests.cpu }}
+ memory: {{ .Values.backups.pgbackrest.repoHost.resources.requests.memory }}
+ {{- end }}
+ {{- if .Values.backups.pgbackrest.containers.pgbackrestConfig.resources.limits }}
+ limits:
+ cpu: {{ .Values.backups.pgbackrest.repoHost.resources.limits.cpu }}
+ memory: {{ .Values.backups.pgbackrest.repoHost.resources.limits.memory }}
+ {{- end }}
+ {{- end }}
priorityClassName: {{ .Values.backups.pgbackrest.repoHost.priorityClassName }}
{{- if .Values.backups.pgbackrest.repoHost.topologySpreadConstraints }}
topologySpreadConstraints:Please feel free to share any feedback! Thanks in advance for your review and support 🙌. |
hors
previously approved these changes
Mar 17, 2025
eleo007
previously approved these changes
Mar 17, 2025
nmarukovich
approved these changes
Mar 17, 2025
eleo007
approved these changes
Mar 17, 2025
|
Thanks for this work ❤️ |
tuotempo
pushed a commit
to tuotempo/percona-helm-charts
that referenced
this pull request
Nov 11, 2025
* K8SPG-651 - Update pg-db and pg-operator charts for 2.6.0 release * Update maintainers * K8SPG-699: Add example for pgvector * K8SPG-554: add `.spec.tlsOnly` (percona#469) https://perconadev.atlassian.net/browse/K8SPG-554 Co-authored-by: Julio Pasinatto <julio.pasinatto@percona.com> * K8SPG-634: Add autoCreateUserSchema field (percona#453) * Add autoCreateUserSchema field. * Add autoCreateUserSchema field in pg-db template --------- Co-authored-by: Julio Pasinatto <julio.pasinatto@percona.com> * K8SPG-676 - Add missing resources requests fields * Update image versions * Update crd and notes * Use resources named template * K8SPG-678 - Remove hard coded values and fixes * K8SPG-619: add `restartPolicy` and `backoffLimit` to `.pgbackrest.jobs` (percona#462) * K8SPG-619: add `restartPolicy` and `backoffLimit` to `.pgbackrest.jobs` https://perconadev.atlassian.net/browse/K8SPG-619 * update README --------- Co-authored-by: Julio Pasinatto <julio.pasinatto@percona.com> * Update db to PG16 * Update rbac and crd * Add finalizer and metadata fields * Add annotations field plus fixes * Add resources filed for pgbackrest.repoHost --------- Co-authored-by: Ege Güneş <ege.gunes@percona.com> Co-authored-by: Andrii Dema <a.dema@jazzserve.com> Co-authored-by: Inel Pandzic <inel.pandzic@percona.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.