[pmm]: add support for initContainers#750
Open
KyriosGN0 wants to merge 2 commits intopercona:mainfrom
Open
Conversation
KyriosGN0
requested review from
idoqo and
maxkondr
and removed request for
a team
idoqo
approved these changes
Dec 29, 2025
Contributor
Author
ademidoff
previously approved these changes
Jan 13, 2026
Contributor
Author
maxkondr
previously approved these changes
Jan 23, 2026
Contributor
Contributor
Author
Contributor
Author
|
hey @ademidoff @maxkondr, had to rebase the PR, could i get an approve and merge here? this would really help me out! |
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds configurable initContainers support to the pmm Helm chart so users can run pre-start tasks (e.g., proxy setup) before the main PMM container starts.
Changes:
- Introduces a new
initContainersvalue invalues.yaml(defaulting to an empty list). - Renders
.Values.initContainersinto the PMM StatefulSet pod spec when provided. - Bumps chart version from
1.5.1to1.6.0.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
charts/pmm/values.yaml |
Adds the new initContainers configurable value (default []). |
charts/pmm/templates/statefulset.yaml |
Conditionally injects initContainers into the pod spec using .Values.initContainers. |
charts/pmm/Chart.yaml |
Chart version bump to reflect the new feature. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: AvivGuiser avivguiser@gmail.com
fixes #749