PMM-14839: Add External Secrets Operator support for OAuth credentials#793
Open
kapendra007 wants to merge 3 commits intopercona:mainfrom
Open
PMM-14839: Add External Secrets Operator support for OAuth credentials#793kapendra007 wants to merge 3 commits intopercona:mainfrom
kapendra007 wants to merge 3 commits intopercona:mainfrom
Conversation
- Add generic externalSecrets configuration to values.yaml - Create external-secret-oauth.yaml template for ESO integration - Update StatefulSet to inject OAuth credentials from ExternalSecret - Support any OAuth provider (Okta, Google, Azure AD, GitHub, GitLab, etc.) - Support any secret backend (Vault, AWS, Azure, GCP, etc.) - Maintain backward compatibility with existing secret management - Update README with parameters documentation and usage examples - Bump chart version from 1.5.1 to 1.5.2 This change enables secure credential management using External Secrets Operator without storing sensitive data in values files. The implementation is provider-agnostic and backend-agnostic, allowing users to integrate with their existing secret management infrastructure. Jira: https://perconadev.atlassian.net/browse/PMM-14839
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for External Secrets Operator (ESO) integration to fetch OAuth credentials from external secret management systems for Grafana authentication in the PMM Helm chart.
Jira Issue
https://perconadev.atlassian.net/browse/PMM-14839
Motivation
Changes Made
1. Generic External Secrets Configuration (
values.yaml)externalSecretssection with OAuth support2. ExternalSecret Template (
templates/external-secret-oauth.yaml)3. StatefulSet Integration (
templates/statefulset.yaml)externalSecrets.oauth.enabledis trueGF_AUTH_GENERIC_OAUTH_CLIENT_IDandGF_AUTH_GENERIC_OAUTH_CLIENT_SECRET4. Documentation (
README.md)5. Chart Version Bump (
Chart.yaml)1.5.1to1.5.2Backward Compatibility
✅ Fully backward compatible - existing deployments are not affected:
externalSecrets.enableddefaults tofalsesecret.create: true) continues to work as beforeTesting
helm lintpasses successfullyhelm templaterenders correctly withexternalSecrets.enabled=truehelm templaterenders correctly withexternalSecrets.enabled=false(default)Usage Example