Skip to content

Conversation

@egegunes
Copy link
Contributor

@egegunes egegunes commented Jan 2, 2025

K8SPG-701 Powered by Pull Request Badge

CHANGE DESCRIPTION

Problem:
spec.extensions.image is required and you need to set it if you just want to enable one of the built-in extensions.

Solution:
Make this field optional and add validation.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PG version?
  • Does the change support oldest and newest supported Kubernetes version?

hors
hors previously approved these changes Jan 2, 2025
inelpandzic
inelpandzic previously approved these changes Jan 2, 2025
nmarukovich
nmarukovich previously approved these changes Jan 6, 2025
@egegunes egegunes dismissed stale reviews from nmarukovich, inelpandzic, and hors via 3944f74 January 6, 2025 14:24
@JNKPercona
Copy link
Collaborator

Test name Status
custom-extensions passed
custom-tls passed
demand-backup passed
finalizers passed
init-deploy passed
monitoring passed
one-pod passed
operator-self-healing passed
pitr passed
scaling passed
scheduled-backup passed
self-healing passed
sidecars passed
start-from-backup passed
tablespaces passed
telemetry-transfer passed
upgrade-consistency passed
upgrade-minor passed
users passed
We run 19 out of 19

commit: 3944f74
image: perconalab/percona-postgresql-operator:PR-1002-3944f7487

@egegunes egegunes merged commit 22d4b48 into main Jan 9, 2025
17 checks passed
@egegunes egegunes deleted the K8SPG-701 branch January 9, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants