-
Notifications
You must be signed in to change notification settings - Fork 67
K8SPG-882 determine patroni version without using the special patroni version check pod #1334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… version check pod
egegunes
previously approved these changes
Oct 28, 2025
hors
previously approved these changes
Oct 28, 2025
nmarukovich
previously approved these changes
Oct 28, 2025
pooknull
previously approved these changes
Oct 29, 2025
cdb5c8d
Contributor
|
@gkech please check unit tests |
egegunes
previously approved these changes
Oct 31, 2025
Collaborator
commit: 898926b |
egegunes
approved these changes
Nov 3, 2025
nmarukovich
approved these changes
Nov 3, 2025
pooknull
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
The current patroni version check implementation can be completely skipped. We can assume by default patroni version 4.x. The operator should be able to determine the patroni version by running a
patronictl versioncommand to an instance pod, database container and assign this value to the pg status, as well to an annotationpgv2.percona.com/patroni-version. Thecustompatroni version annotation option will not continue to be support with this version.For cr 2.7 and older, the
pgv2.percona.com/custom-patroni-versionshould continue to work. The patroni version check pod also should continue working for these cr versions.Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Short explanation of the solution we are providing with this PR.
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
Config/Logging/Testability