K8SPG-648 add PG17 support #921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pooknull
requested review from
egegunes,
eleo007,
inelpandzic,
jvpasinatto,
nmarukovich,
pooknull,
ptankov and
tplavcic
as code owners
inelpandzic
previously approved these changes
Dec 11, 2024
egegunes
reviewed
Dec 20, 2024
| // +kubebuilder:rbac:groups=apps,resources=replicasets,verbs=create;delete;get;list;patch;watch | ||
| // +kubebuilder:rbac:groups=pgv2.percona.com,resources=perconapgclusters/finalizers,verbs=update | ||
| // +kubebuilder:rbac:groups=batch,resources=jobs,verbs=create;list;update | ||
| // +kubebuilder:rbac:groups=pgv2.percona.com,resources=pods,verbs=create;delete |
Contributor
There was a problem hiding this comment.
do we have pods resource in this api group?
| } | ||
|
|
||
| if err := r.Client.Create(ctx, p); err != nil { | ||
| return errors.Wrap(err, "failed to create pod to check patrni version") |
Contributor
There was a problem hiding this comment.
Suggested change
| return errors.Wrap(err, "failed to create pod to check patrni version") | |
| return errors.Wrap(err, "failed to create pod to check patroni version") |
internal/patroni/api.go
Outdated
| // next cannot be blank. Similar to the "POST /switchover" REST endpoint. | ||
| func (exec Executor) ChangePrimaryAndWait( | ||
| ctx context.Context, current, next string, | ||
| ctx context.Context, current, next string, ver4 bool, |
Contributor
There was a problem hiding this comment.
i would name this patroniVer4 to be more clear
inelpandzic
reviewed
Dec 20, 2024
egegunes
requested changes
Jan 6, 2025
Comment on lines
99
to
107
| patroniVerStr, ok := cluster.Annotations[pNaming.ToCrunchyAnnotation(pNaming.AnnotationPatroniVersion)] | ||
| if !ok { | ||
| return errors.New("patroni version annotation was not found") | ||
| } | ||
| patroniVer, err := gover.NewVersion(patroniVerStr) | ||
| if err != nil { | ||
| return errors.Wrap(err, "failed to get patroni ver") | ||
| } | ||
| patroniVer4 := patroniVer.Compare(gover.Must(gover.NewVersion("4.0.0"))) >= 0 |
Contributor
There was a problem hiding this comment.
i see we do this in multiple places, can we move this logic to a function?
Contributor
There was a problem hiding this comment.
also i don't think we should use gover.Must since it'll panic if it can't parse the version
internal/patroni/api.go
Outdated
| // We should use "primary" instead | ||
| cmd := []string{"patronictl", "switchover", "--scheduled=now", "--force", "--primary=" + current, "--candidate=" + next} | ||
| if !patroniVer4 { | ||
| cmd = []string{"patronictl", "switchover", "--scheduled=now", "--force", "--master=" + current, "--candidate=" + next} |
Contributor
There was a problem hiding this comment.
rather than duplicating the slice, can we do smth like cmd[4] = "--master=" + current?
Collaborator
commit: 9fc8f82 |
egegunes
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
Short explanation of the problem.
Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Short explanation of the solution we are providing with this PR.
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
Config/Logging/Testability