Skip to content

K8SPG-619: restart backup jobs on failure #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hors merged 15 commits into from
Jan 2, 2025
Merged

K8SPG-619: restart backup jobs on failure #969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
09a5bff
K8SPG-619: restart backup jobs on failure
pooknull Dec 3, 2024
adb83ce
fix unit-test
pooknull Dec 3, 2024
d109270
Merge branch 'main' into K8SPG-619
pooknull Dec 3, 2024
a50d1b0
Merge branch 'main' into K8SPG-619
hors Dec 10, 2024
f01c9bb
Add backoffLimit and restartPolicy to .spec.backups.pgbackrest.jobs
pooknull Dec 12, 2024
5080f96
fix unit-tests
pooknull Dec 16, 2024
aaa2c86
fix upgrade-minor test
pooknull Dec 16, 2024
57b343e
Merge remote-tracking branch 'origin/main' into K8SPG-619
pooknull Dec 18, 2024
450fbd4
fix unit-tests
pooknull Dec 18, 2024
39c7804
keep defaults
pooknull Dec 23, 2024
d8b4d5d
Merge branch 'main' into K8SPG-619
pooknull Dec 23, 2024
ae72c0d
Merge branch 'main' into K8SPG-619
hors Dec 27, 2024
a4cab0c
Merge branch 'main' into K8SPG-619
hors Dec 27, 2024
48ed896
Merge branch 'main' into K8SPG-619
hors Dec 27, 2024
8460d9f
Merge branch 'main' into K8SPG-619
hors Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/crd/crunchy/generated/postgres-operator.crunchydata.com_pgupgrades.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.3
controller-gen.kubebuilder.io/version: v0.16.5
name: pgupgrades.postgres-operator.crunchydata.com
spec:
group: postgres-operator.crunchydata.com
Expand Down
12 changes: 11 additions & 1 deletion build/crd/crunchy/generated/postgres-operator.crunchydata.com_postgresclusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.3
controller-gen.kubebuilder.io/version: v0.16.5
name: postgresclusters.postgres-operator.crunchydata.com
spec:
group: postgres-operator.crunchydata.com
Expand Down Expand Up @@ -1331,6 +1331,9 @@ spec:
x-kubernetes-list-type: atomic
type: object
type: object
backoffLimit:
format: int32
type: integer
priorityClassName:
description: |-
Priority class name for the pgBackRest backup Job pods.
Expand Down Expand Up @@ -1398,6 +1401,13 @@ spec:
More info: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/
type: object
type: object
restartPolicy:
description: |-
RestartPolicy describes how the container should be restarted.
Only one of the following restart policies may be specified.
If none of the following policies is specified, the default one
is RestartPolicyAlways.
type: string
securityContext:
description: SecurityContext defines the security settings
for PGBackRest pod.
Expand Down
2 changes: 1 addition & 1 deletion build/crd/percona/generated/pgv2.percona.com_perconapgbackups.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.3
controller-gen.kubebuilder.io/version: v0.16.5
name: perconapgbackups.pgv2.percona.com
spec:
group: pgv2.percona.com
Expand Down
12 changes: 11 additions & 1 deletion build/crd/percona/generated/pgv2.percona.com_perconapgclusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.3
controller-gen.kubebuilder.io/version: v0.16.5
name: perconapgclusters.pgv2.percona.com
spec:
group: pgv2.percona.com
Expand Down Expand Up @@ -1487,6 +1487,9 @@ spec:
x-kubernetes-list-type: atomic
type: object
type: object
backoffLimit:
format: int32
type: integer
priorityClassName:
description: |-
Priority class name for the pgBackRest backup Job pods.
Expand Down Expand Up @@ -1554,6 +1557,13 @@ spec:
More info: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/
type: object
type: object
restartPolicy:
description: |-
RestartPolicy describes how the container should be restarted.
Only one of the following restart policies may be specified.
If none of the following policies is specified, the default one
is RestartPolicyAlways.
type: string
securityContext:
description: SecurityContext defines the security settings
for PGBackRest pod.
Expand Down
2 changes: 1 addition & 1 deletion build/crd/percona/generated/pgv2.percona.com_perconapgrestores.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.3
controller-gen.kubebuilder.io/version: v0.16.5
name: perconapgrestores.pgv2.percona.com
spec:
group: pgv2.percona.com
Expand Down
2 changes: 1 addition & 1 deletion build/crd/percona/generated/pgv2.percona.com_perconapgupgrades.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.3
controller-gen.kubebuilder.io/version: v0.16.5
name: perconapgupgrades.pgv2.percona.com
spec:
group: pgv2.percona.com
Expand Down
18 changes: 14 additions & 4 deletions config/crd/bases/pgv2.percona.com_perconapgclusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.3
controller-gen.kubebuilder.io/version: v0.16.5
name: perconapgbackups.pgv2.percona.com
spec:
group: pgv2.percona.com
Expand Down Expand Up @@ -409,7 +409,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.3
controller-gen.kubebuilder.io/version: v0.16.5
name: perconapgclusters.pgv2.percona.com
spec:
group: pgv2.percona.com
Expand Down Expand Up @@ -1893,6 +1893,9 @@ spec:
x-kubernetes-list-type: atomic
type: object
type: object
backoffLimit:
format: int32
type: integer
priorityClassName:
description: |-
Priority class name for the pgBackRest backup Job pods.
Expand Down Expand Up @@ -1960,6 +1963,13 @@ spec:
More info: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/
type: object
type: object
restartPolicy:
description: |-
RestartPolicy describes how the container should be restarted.
Only one of the following restart policies may be specified.
If none of the following policies is specified, the default one
is RestartPolicyAlways.
type: string
securityContext:
description: SecurityContext defines the security settings
for PGBackRest pod.
Expand Down Expand Up @@ -17969,7 +17979,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.3
controller-gen.kubebuilder.io/version: v0.16.5
name: perconapgrestores.pgv2.percona.com
spec:
group: pgv2.percona.com
Expand Down Expand Up @@ -18067,7 +18077,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.3
controller-gen.kubebuilder.io/version: v0.16.5
name: perconapgupgrades.pgv2.percona.com
spec:
group: pgv2.percona.com
Expand Down
2 changes: 1 addition & 1 deletion config/crd/bases/postgres-operator.crunchydata.com_crunchybridgeclusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.3
controller-gen.kubebuilder.io/version: v0.16.5
labels:
app.kubernetes.io/name: pgo
app.kubernetes.io/version: latest
Expand Down
2 changes: 1 addition & 1 deletion config/crd/bases/postgres-operator.crunchydata.com_pgadmins.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.3
controller-gen.kubebuilder.io/version: v0.16.5
labels:
app.kubernetes.io/name: pgo
app.kubernetes.io/version: latest
Expand Down
2 changes: 1 addition & 1 deletion config/crd/bases/postgres-operator.crunchydata.com_pgupgrades.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.3
controller-gen.kubebuilder.io/version: v0.16.5
labels:
app.kubernetes.io/name: pgo
app.kubernetes.io/version: latest
Expand Down
12 changes: 11 additions & 1 deletion config/crd/bases/postgres-operator.crunchydata.com_postgresclusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.3
controller-gen.kubebuilder.io/version: v0.16.5
labels:
app.kubernetes.io/name: pgo
app.kubernetes.io/version: 5.4.2
Expand Down Expand Up @@ -1323,6 +1323,9 @@ spec:
x-kubernetes-list-type: atomic
type: object
type: object
backoffLimit:
format: int32
type: integer
priorityClassName:
description: |-
Priority class name for the pgBackRest backup Job pods.
Expand Down Expand Up @@ -1390,6 +1393,13 @@ spec:
More info: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/
type: object
type: object
restartPolicy:
description: |-
RestartPolicy describes how the container should be restarted.
Only one of the following restart policies may be specified.
If none of the following policies is specified, the default one
is RestartPolicyAlways.
type: string
securityContext:
description: SecurityContext defines the security settings
for PGBackRest pod.
Expand Down
36 changes: 28 additions & 8 deletions deploy/bundle.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.3
controller-gen.kubebuilder.io/version: v0.16.5
labels:
app.kubernetes.io/name: pgo
app.kubernetes.io/version: latest
Expand Down Expand Up @@ -295,7 +295,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.3
controller-gen.kubebuilder.io/version: v0.16.5
name: perconapgbackups.pgv2.percona.com
spec:
group: pgv2.percona.com
Expand Down Expand Up @@ -702,7 +702,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.3
controller-gen.kubebuilder.io/version: v0.16.5
name: perconapgclusters.pgv2.percona.com
spec:
group: pgv2.percona.com
Expand Down Expand Up @@ -2186,6 +2186,9 @@ spec:
x-kubernetes-list-type: atomic
type: object
type: object
backoffLimit:
format: int32
type: integer
priorityClassName:
description: |-
Priority class name for the pgBackRest backup Job pods.
Expand Down Expand Up @@ -2253,6 +2256,13 @@ spec:
More info: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/
type: object
type: object
restartPolicy:
description: |-
RestartPolicy describes how the container should be restarted.
Only one of the following restart policies may be specified.
If none of the following policies is specified, the default one
is RestartPolicyAlways.
type: string
securityContext:
description: SecurityContext defines the security settings
for PGBackRest pod.
Expand Down Expand Up @@ -18262,7 +18272,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.3
controller-gen.kubebuilder.io/version: v0.16.5
name: perconapgrestores.pgv2.percona.com
spec:
group: pgv2.percona.com
Expand Down Expand Up @@ -18360,7 +18370,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.3
controller-gen.kubebuilder.io/version: v0.16.5
name: perconapgupgrades.pgv2.percona.com
spec:
group: pgv2.percona.com
Expand Down Expand Up @@ -21072,7 +21082,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.3
controller-gen.kubebuilder.io/version: v0.16.5
labels:
app.kubernetes.io/name: pgo
app.kubernetes.io/version: latest
Expand Down Expand Up @@ -22976,7 +22986,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.3
controller-gen.kubebuilder.io/version: v0.16.5
labels:
app.kubernetes.io/name: pgo
app.kubernetes.io/version: latest
Expand Down Expand Up @@ -25677,7 +25687,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.3
controller-gen.kubebuilder.io/version: v0.16.5
labels:
app.kubernetes.io/name: pgo
app.kubernetes.io/version: 5.4.2
Expand Down Expand Up @@ -26998,6 +27008,9 @@ spec:
x-kubernetes-list-type: atomic
type: object
type: object
backoffLimit:
format: int32
type: integer
priorityClassName:
description: |-
Priority class name for the pgBackRest backup Job pods.
Expand Down Expand Up @@ -27065,6 +27078,13 @@ spec:
More info: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/
type: object
type: object
restartPolicy:
description: |-
RestartPolicy describes how the container should be restarted.
Only one of the following restart policies may be specified.
If none of the following policies is specified, the default one
is RestartPolicyAlways.
type: string
securityContext:
description: SecurityContext defines the security settings
for PGBackRest pod.
Expand Down
2 changes: 2 additions & 0 deletions deploy/cr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,8 @@ spec:
# - secret:
# name: cluster1-pgbackrest-secrets
# jobs:
# restartPolicy: OnFailure
Copy link
Collaborator

@hors hors Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not change the defaults. We need to add the possibility of configuring it, but we need to have the old behavior by default.

Copy link
Contributor Author

@pooknull pooknull Dec 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

39c7804

# backoffLimit: 2
# priorityClassName: high-priority
# resources:
# limits:
Expand Down
Loading
Loading