K8SPSMDB-1109: Add filesystem storage support for backups/restores #1682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| compare_mongo_cmd "find" "myApp:myPass@${cluster}-rs0.${namespace}" "${find_prefix}" ".svc.cluster.local" "myApp" "test" | ||
| } | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
hors
requested changes
Oct 24, 2024
| required: | ||
| - credentialsSecret | ||
| type: object | ||
| filesystem: |
Collaborator
There was a problem hiding this comment.
please update cr.yaml as well and please create helm PR :)
egegunes
requested review from
eleo007,
inelpandzic,
jvpasinatto,
nmarukovich,
pooknull,
ptankov and
tplavcic
as code owners
inelpandzic
reviewed
Oct 28, 2024
Contributor
inelpandzic
left a comment
inelpandzic
left a comment
There was a problem hiding this comment.
This looks good. Just pls add example to cr.yaml.
egegunes
commented
Oct 28, 2024
Comment on lines
+48
to
+50
| nfs: | ||
| server: "nfs-service.storage.svc.cluster.local" | ||
| path: "/psmdb-some-name-rs0" |
Contributor
Author
There was a problem hiding this comment.
do we have more parameters here that k8s supports?
inelpandzic
previously approved these changes
Oct 30, 2024
pull-request-size
bot
added
size/XXL
inelpandzic
approved these changes
Nov 11, 2024
hors
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
Filesystem backups are not supported.
Solution:
We already had most of the required mechanisms to enable backups to filesystem. This PR just adds
VolumeMountsto backup section, so user can configure their volumes inspec.replsets[].sidecarVolumesand mount them usingspec.backups.volumeMounts.CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
compare/*-oc.yml)?Config/Logging/Testability