K8SPSMDB-1075 use controller runtime builder #1692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
nmarukovich
requested review from
egegunes,
hors,
inelpandzic and
pooknull
as code owners
….com:percona/percona-server-mongodb-operator into K8SPSMDB-1075_use_controller_runtime_builder
inelpandzic
previously approved these changes
Nov 5, 2024
egegunes
reviewed
Nov 15, 2024
pkg/controller/perconaservermongodbrestore/perconaservermongodbrestore_controller.go
Outdated
Show resolved
Hide resolved
….com:percona/percona-server-mongodb-operator into K8SPSMDB-1075_use_controller_runtime_builder
…backup_controller.go Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| "github.com/percona/percona-backup-mongodb/pbm/storage/azure" | ||
| "github.com/percona/percona-backup-mongodb/pbm/storage/s3" | ||
|
|
||
| "github.com/percona/percona-server-mongodb-operator/clientcmd" |
Contributor
There was a problem hiding this comment.
[goimports-reviser] reported by reviewdog 🐶
Suggested change
| "github.com/percona/percona-server-mongodb-operator/clientcmd" | |
| "github.com/percona/percona-server-mongodb-operator/clientcmd" |
egegunes
approved these changes
Nov 25, 2024
Comment on lines
-180
to
-188
| // TODO: Remove after 1.15 | ||
| if cluster.CompareVersion("1.12.0") >= 0 && cr.Spec.ClusterName == "" { | ||
| cr.Spec.ClusterName = cr.Spec.PSMDBCluster | ||
| cr.Spec.PSMDBCluster = "" | ||
| err = r.client.Update(ctx, cr) | ||
| if err != nil { | ||
| return rr, errors.Wrap(err, "failed to update clusterName") | ||
| } | ||
| } |
pooknull
approved these changes
Nov 25, 2024
inelpandzic
approved these changes
Nov 25, 2024
Collaborator
commit: 45ff87f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
Short explanation of the problem.
Use controller runtime builder to configure controllers
Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Short explanation of the solution we are providing with this PR.
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
compare/*-oc.yml)?Config/Logging/Testability