K8SPSMDB-1212: Don't disable balancer during restore #1710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egegunes
force-pushed
the
K8SPSMDB-1212
branch
from
8eb5ae4 to
e622a56
Compare
pull-request-size
bot
added
size/XL
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| fi | ||
| } | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
egegunes
changed the title
egegunes
force-pushed
the
K8SPSMDB-1212
branch
3 times, most recently
from
60e1af2 to
9e4f2b9
Compare
egegunes
changed the title
egegunes
force-pushed
the
K8SPSMDB-1212
branch
from
9e4f2b9 to
7155578
Compare
egegunes
requested review from
eleo007,
hors,
inelpandzic,
jvpasinatto,
nmarukovich,
pooknull and
ptankov
as code owners
hors
previously approved these changes
Nov 17, 2024
inelpandzic
previously approved these changes
Nov 18, 2024
pooknull
previously approved these changes
Nov 21, 2024
egegunes
dismissed stale reviews from hors, inelpandzic, and pooknull
via
1cdf4d6
inelpandzic
previously approved these changes
Dec 4, 2024
hors
previously approved these changes
Dec 4, 2024
egegunes
force-pushed
the
K8SPSMDB-1212
branch
from
1eeb963 to
60691b3
Compare
pull-request-size
bot
added
size/L
inelpandzic
reviewed
Dec 11, 2024
Contributor
inelpandzic
left a comment
inelpandzic
left a comment
There was a problem hiding this comment.
This looks good. Pls just check those failing tests.
| bash -c "printf '$command\n' | mongosh --quiet $driver://$uri$suffix/admin?ssl=false\&replicaSet=$replica_set $mongo_flag" | ||
| } | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
Collaborator
commit: 0287bd3 |
hors
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
Operator disables balancer during restore.
Cause:
Old behavior from PBM v1 days.
Solution:
Operator shouldn't disable balancer during restores. Balancer should only be disabled during backups and PBM v2 already does that.
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
compare/*-oc.yml)?Config/Logging/Testability