Conversation
don't skip hidden in setVotes fix physical restores with hidden members e2e test fix smart update
egegunes
requested review from
eleo007,
gkech,
hors,
jvpasinatto,
nmarukovich and
pooknull
as code owners
gkech
reviewed
May 22, 2025
Comment on lines
+866
to
+901
| if h.LivenessProbe == nil { | ||
| h.LivenessProbe = new(LivenessProbeExtended) | ||
| } | ||
| if h.LivenessProbe.InitialDelaySeconds < 1 { | ||
| h.LivenessProbe.InitialDelaySeconds = rs.LivenessProbe.InitialDelaySeconds | ||
| } | ||
| if h.LivenessProbe.TimeoutSeconds < 1 { | ||
| h.LivenessProbe.TimeoutSeconds = rs.LivenessProbe.TimeoutSeconds | ||
| } | ||
| if h.LivenessProbe.PeriodSeconds < 1 { | ||
| h.LivenessProbe.PeriodSeconds = rs.LivenessProbe.PeriodSeconds | ||
| } | ||
| if h.LivenessProbe.FailureThreshold < 1 { | ||
| h.LivenessProbe.FailureThreshold = rs.LivenessProbe.FailureThreshold | ||
| } | ||
| if h.LivenessProbe.StartupDelaySeconds < 1 { | ||
| h.LivenessProbe.StartupDelaySeconds = rs.LivenessProbe.StartupDelaySeconds | ||
| } | ||
| if h.LivenessProbe.ProbeHandler.Exec == nil { | ||
| h.LivenessProbe.Probe.ProbeHandler.Exec = &corev1.ExecAction{ | ||
| Command: []string{"/opt/percona/mongodb-healthcheck", "k8s", "liveness"}, | ||
| } | ||
|
|
||
| if cr.TLSEnabled() { | ||
| h.LivenessProbe.Probe.ProbeHandler.Exec.Command = append( | ||
| h.LivenessProbe.Probe.ProbeHandler.Exec.Command, | ||
| "--ssl", "--sslInsecure", "--sslCAFile", "/etc/mongodb-ssl/ca.crt", "--sslPEMKeyFile", "/tmp/tls.pem", | ||
| ) | ||
| } | ||
| } | ||
| startupDelaySecondsFlag := "--startupDelaySeconds" | ||
| if !h.LivenessProbe.CommandHas(startupDelaySecondsFlag) { | ||
| h.LivenessProbe.ProbeHandler.Exec.Command = append( | ||
| h.LivenessProbe.ProbeHandler.Exec.Command, | ||
| startupDelaySecondsFlag, strconv.Itoa(h.LivenessProbe.StartupDelaySeconds)) | ||
| } |
Contributor
There was a problem hiding this comment.
optional: Given that this whole block is focused on liveness, maybe we could extract it to a function like the following:
func (h *HiddenSpec) setLivenessProbe(cr *PerconaServerMongoDB, rs *ReplsetSpec)
It is not that the current share is complicated or anything, but I think the extraction helps readability. Right now has too much detail.
Contributor
There was a problem hiding this comment.
We can do something similar for the readiness probe.
| case naming.ComponentNonVoting: | ||
| pdbspec = rs.NonVoting.PodDisruptionBudget | ||
| volumeSpec = rs.NonVoting.VolumeSpec | ||
| case naming.ComponentHidden: |
Contributor
There was a problem hiding this comment.
Given that we added a new case of replsets, I think it would be nice to have a new test case in our statefulset_test.go file, on the TestReconcileStatefulSet set. We have already covered these:
- mongod
- arbiter
- non-voting
gkech
reviewed
May 22, 2025
Comment on lines
+326
to
+329
| member.Tags = util.MapMerge(mongo.ReplsetTags{ | ||
| naming.ComponentHidden: "true", | ||
| }, tags) | ||
| member.Priority = 0 |
Contributor
There was a problem hiding this comment.
From what I understand by reading the documentation, the only configuration needed to setup a hidden replica set contains these 2 properties: 1) priority 0 and 2) the hidden tag equal to true. Correct?
gkech
previously approved these changes
May 22, 2025
egegunes
force-pushed
the
K8SPSMDB-723
branch
2 times, most recently
from
ba7f7d9 to
8350a68
Compare
Collaborator
commit: 18ea724 |
gkech
approved these changes
May 26, 2025
hors
approved these changes
May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
This PR makes it possible to deploy hidden replicaset members. Implementation is almost identical to non-voting members: Operator will create a separate statefulset for hidden members and properyly configure them in replset.
Hidden members are tested together with non-voting members in
non-voting-and-hiddentest.CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
compare/*-oc.yml)?Config/Logging/Testability