-
Notifications
You must be signed in to change notification settings - Fork 156
feat: support containers env paramater setting #1987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@cccfs implementation LGTM, please add a case for this new field into |
for _, env := range cr.Spec.Sharding.Mongos.ContainerEnv { | ||
container.Env = append(container.Env, env) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can simplify this by using golang's unfurl feature
container.Env = append(container.Env, cr.Spec.Sharding.Mongos.ContainerEnv...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can do the same for all the related diff changes
commit: 82b5284 |
CHANGE DESCRIPTION
Problem:
My log-agent generates index configuration by scanning container env and ultimately collects container logs for remote storage, so it needs to support custom pod env configuration
Solution:
Ensure that replica sets and shard mongos support containers env configuration
CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
compare/*-oc.yml
)?Config/Logging/Testability