K8SPSMDB-1542: use startingDeadlineSeconds for PBM#2156
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new configurable field pbmStartingDeadlineSeconds to the BackupSpec API, allowing users to customize the timeout for backups stuck in the "starting" state. The default timeout remains 120 seconds, with the ability to override it at the cluster backup specification level.
Key Changes
- New
PBMStartingDeadlineSecondsfield added to BackupSpec with int64 type - Updated backup status logic to use the configurable timeout instead of hardcoded value
- Test coverage added for custom deadline scenarios
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/apis/psmdb/v1/psmdb_types.go | Adds PBMStartingDeadlineSeconds field to BackupSpec struct |
| pkg/apis/psmdb/v1/zz_generated.deepcopy.go | Auto-generated DeepCopy method for the new field |
| pkg/controller/perconaservermongodbbackup/backup.go | Updates timeout logic to use configurable value with default fallback |
| pkg/controller/perconaservermongodbbackup/psmdb_backup_controller.go | Passes cluster parameter to Status method |
| pkg/controller/perconaservermongodbbackup/backup_test.go | Adds test case for custom deadline scenario |
| config/crd/bases/psmdb.percona.com_perconaservermongodbs.yaml | Adds CRD schema definition for new field |
| deploy/crd.yaml | Adds CRD schema definition for new field |
| deploy/bundle.yaml | Adds CRD schema definition for new field |
| deploy/cw-bundle.yaml | Adds CRD schema definition for new field |
| e2e-tests/version-service/conf/crd.yaml | Adds CRD schema definition for new field |
| deploy/cr.yaml | Adds commented example configuration with default value |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pooknull
requested review from
egegunes,
eleo007,
gkech,
hors,
jvpasinatto,
nmarukovich and
valmiranogueira
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pooknull
changed the title
pbmStartingDeadlineSeconds fieldstartingDeadlineSeconds for PBM
egegunes
previously approved these changes
Dec 23, 2025
| Configuration BackupConfig `json:"configuration,omitempty"` | ||
| VolumeMounts []corev1.VolumeMount `json:"volumeMounts,omitempty"` | ||
| StartingDeadlineSeconds *int64 `json:"startingDeadlineSeconds,omitempty"` | ||
| // +kubebuilder:validation:Minimum=1 |
Member
There was a problem hiding this comment.
Suggested change
| // +kubebuilder:validation:Minimum=1 | |
| // +kubebuilder:validation:Minimum=1 | |
| // +kubebuilder:default:=120 |
Member
mayankshah1607
left a comment
mayankshah1607
left a comment
There was a problem hiding this comment.
LGTM, just one suggestion
gkech
previously approved these changes
Jan 5, 2026
pooknull
requested review from
bogdanjeler-ev and
oksana-grishchenko
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gkech
approved these changes
Jan 5, 2026
mayankshah1607
approved these changes
Jan 5, 2026
egegunes
approved these changes
Jan 6, 2026
Collaborator
commit: 29266b5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/K8SPSMDB-1542
DESCRIPTION
This PR makes operator to use a
.spec.backup.startingDeadlineSecondsas a deadline for PBM backup being in starting status. If this field is not specified, it defaults to 120 secondsCHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
compare/*-oc.yml)?Config/Logging/Testability