-
Notifications
You must be signed in to change notification settings - Fork 168
K8SPSMDB-1520: fix minio backup deletion failure #2211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Mayank Shah <mayank.shah@percona.com>
Signed-off-by: Mayank Shah <mayank.shah@percona.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds support for Minio storage type in the backup deletion finalizer logic to fix a "no storage info in backup status" error when deleting Minio backups.
Changes:
- Added Minio storage case handling in the
getPBMStoragefunction to support backup deletion - Updated test configuration to use the Minio storage type instead of S3
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| pkg/controller/perconaservermongodbbackup/psmdb_backup_controller.go | Added import for mio storage package and implemented Minio case block in getPBMStorage function to create storage configuration from CR status |
| e2e-tests/demand-backup/conf/some-name-rs0.yml | Updated storage type from "s3" to "minio", adjusted endpoint URL format, and added "secure: false" field |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pkg/controller/perconaservermongodbbackup/psmdb_backup_controller.go
Outdated
Show resolved
Hide resolved
…ler.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Mayank Shah <mayank.shah@percona.com>
Signed-off-by: Mayank Shah <mayank.shah@percona.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
commit: 93bbeff |
Signed-off-by: Mayank Shah <mayank.shah@percona.com>
Signed-off-by: Mayank Shah <mayank.shah@percona.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Due to the high volume of requests, we're unable to provide free service for this account. To continue using the service, please upgarde to a paid plan.
CHANGE DESCRIPTION
Problem:
Deleting a minio backup fails with error:
Cause:
Finalizer handling logic is missing some minio-specific logic
Fix finalizer handler to take minio storage into account as well
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
compare/*-oc.yml)?Config/Logging/Testability