PSMDB-1884: fix clang-tidy workflow #1645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plebioda
force-pushed
the
PSMDB-1884-fix-clang-tidy-reporting
branch
4 times, most recently
from
1d8d6c7 to
a65f52f
Compare
There was a problem hiding this comment.
Pull request overview
This PR fixes the clang-tidy CI workflow by adding AWS SDK C++ setup and updating build configurations to properly support clang-tidy analysis.
Key changes:
- Added AWS SDK C++ setup action for building and caching the SDK
- Updated clang-tidy workflow to use clang compiler and proper build flags
- Added system dependencies installation to the setup-env action
- Modified wrapper hook to insert bazel arguments before the
--separator
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
bazel/wrapper_hook/wrapper_hook.py |
Added append_args function to insert arguments before -- separator and updated argument handling logic |
.github/workflows/clang-tidy.yml |
Added AWS SDK setup step and configured compiler type to clang for proper clang-tidy analysis |
.github/actions/setup-env/action.yml |
Added installation of system dependencies required for building |
.github/actions/setup-aws-sdk/action.yml |
New action to build and cache AWS SDK C++ with specific configuration for S3 and transfer components |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The arguments shall be appended after the '--' separator arg if exists.
plebioda
force-pushed
the
PSMDB-1884-fix-clang-tidy-reporting
branch
2 times, most recently
from
0a158dc to
256fc49
Compare
plebioda
force-pushed
the
PSMDB-1884-fix-clang-tidy-reporting
branch
from
256fc49 to
6420f6e
Compare
plebioda
force-pushed
the
PSMDB-1884-fix-clang-tidy-reporting
branch
3 times, most recently
from
46af858 to
edd933a
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fix clang-tidy workflow reporting the errors related to missing includes by installing dependencies and building the AWS SDK. Fix generating compile_commands.json: - use the `--intree_compdb` option which fixes a problem with absolute paths in compiler flags, - use //bazel/config:compiler_type=clang to fix missing builtin errors.
The `bazel run format` calls the `git merge-base HEAD origin/<base>` command. Using the `tj-actions/changed-files@v45` action is not reliable.
plebioda
force-pushed
the
PSMDB-1884-fix-clang-tidy-reporting
branch
from
edd933a to
7d94662
Compare
ktrushin
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
clang-tidyanalysis in PR #1637 reported a lot of errors. This is a follow-up PR to fix all of the reported errors.