PSMDB-1922 Require authorization for auditGetOptions command#1667
Merged
PSMDB-1922 Require authorization for auditGetOptions command#1667
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds authorization requirements to the auditGetOptions command for enhanced security. Previously, the command had no authorization checks and simply returned OK for any user.
Changes:
- Added
adminOnly()method to restrict command execution to the admin database - Implemented proper authorization check requiring
getParameteraction privilege on cluster resource - Added parameter names to
checkAuthForOperationmethod signature for clarity
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
plebioda
approved these changes
Jan 28, 2026
plebioda
left a comment
plebioda
left a comment
There was a problem hiding this comment.
Looks good. However, I would suggest to add a some test for this change.
ktrushin
approved these changes
Jan 29, 2026
ktrushin
left a comment
ktrushin
left a comment
There was a problem hiding this comment.
Looks good. It would be nice to have a test, though.
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With these changes auditGetOptions command will require admin db and getParameter action privilege.