PSMDB-1925 Recognize 'psmdb-x.y.x' tags in 'set_mongo_variables.py'#1669
Merged
PSMDB-1925 Recognize 'psmdb-x.y.x' tags in 'set_mongo_variables.py'#1669
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Bazel wrapper hook so it correctly derives MONGO_VERSION when the Git tag uses the Percona-style psmdb-x.y.z prefix, in addition to the existing upstream r-prefixed tags.
Changes:
- Adjusts
get_mongo_version()to strip either an upstreamrprefix or a Perconapsmdb-prefix from thegit describe --abbrev=0output, returning the cleaned version string. - Leaves the rest of the Bazel
.bazelrc.mongo_variablesgeneration logic unchanged, so only tag parsing behavior is modified.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
plebioda
approved these changes
Jan 29, 2026
plebioda
left a comment
plebioda
left a comment
There was a problem hiding this comment.
Looks good, except one minor comment/question.
igorsol
force-pushed
the
psmdb-1925-igor
branch
from
5f3c4a6 to
efc53c6
Compare
plebioda
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes the issue with 'psmdb-x.y.x' tags during the build