Merged
Conversation
plebioda
force-pushed
the
PSMDB-1934-fix-clang-tidy-workflow-master
branch
from
c59848b to
417597c
Compare
Remove bazel cache, don't checkout shallow repo, explicitly fetch tags for `git describe`, ignore changes in MODULE.bazel.lock for format check.
plebioda
force-pushed
the
PSMDB-1934-fix-clang-tidy-workflow-master
branch
from
417597c to
21f3486
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates CI workflows to make the clang-tidy job more reliable and to prevent spurious failures related to Bazel-generated files and Git tag resolution.
Changes:
- In the format workflow, ignore changes to
MODULE.bazel.lockwhen checking for uncommitted formatting changes so Bazel updates do not fail the job. - In the clang-tidy workflow, use a full-depth checkout and explicitly fetch tags to support
git describe, and remove the Bazel cache step that is no longer desired. - Keep the existing clang-tidy SARIF cache and analysis steps intact while adjusting only the source checkout and tag handling.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/format.yml | Ensures the formatting check disregards Bazel’s MODULE.bazel.lock updates before running git diff. |
| .github/workflows/clang-tidy.yml | Adjusts checkout depth and tag fetching for reliable git describe usage and removes the Bazel build cache from the clang-tidy job. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
igorsol
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove bazel cache, don't checkout shallow repo, explicitly fetch tags
for
git describe.