Conversation
olexandr-havryliak
force-pushed
the
PSMDB-1893-test-80
branch
from
45ab6a9 to
6c6a77d
Compare
igorsol
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a new test script to verify the behavior of server parameters that control the inclusion of the
disksandmountssubsections undersystemMetricsin FTDC diagnostic data. The test ensures that these subsections are correctly included or omitted based on the values of thediagnosticDataCollectionEnableSystemMetricsDisksanddiagnosticDataCollectionEnableSystemMetricsMountsparameters, both at startup and when changed at runtime.Key additions and their purposes:
New FTDC system metrics parameter tests:
jstests/noPassthrough/ftdc_system_metrics_disks_mounts_params.jsto verify that thedisksandmountssubsections insystemMetricsare controlled by their respective server parameters, testing both startup and runtime changes.assertSystemMetricsSubsectionto assert the presence or absence of a given subsection in FTDC system metrics, improving test clarity and reducing duplication.Anything in this description will be included in the commit message. Replace or delete this text before merging. Add links to testing in the comments of the PR.