K8SPS-623: fix GCS backups #1194
Open
+13
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes GCS backups by correcting the secret key names used to retrieve GCS credentials. Previously, GCS backups were using AWS-specific key names (AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY) when they should have been using GCS-specific key names (ACCESS_KEY_ID and SECRET_ACCESS_KEY).
Changes:
- Fixed GCS backup secret key references to use correct GCS-specific constants
- Updated S3 backup secret key references to use constants from the secret package instead of hardcoded strings
- Renamed local variable from
secrettosto avoid shadowing the imported secret package
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pooknull
requested review from
egegunes,
gkech,
hors and
nmarukovich
as code owners
egegunes
approved these changes
Jan 23, 2026
nmarukovich
approved these changes
Jan 26, 2026
Collaborator
commit: 956872e |
gkech
reviewed
Jan 26, 2026
| } | ||
| accessKeyID := string(secret.Data["AWS_ACCESS_KEY_ID"]) | ||
| secretAccessKey := string(secret.Data["AWS_SECRET_ACCESS_KEY"]) | ||
| accessKeyID := string(s.Data[secret.CredentialsGCSAccessKey]) |
Contributor
There was a problem hiding this comment.
Why don't we ensure that the data actually contain the expected key?
e.g.
accessKeyBytes, ok := s.Data[secret.CredentialsGCSAccessKey]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the high volume of requests, we're unable to provide free service for this account. To continue using the service, please upgarde to a paid plan.
https://perconadev.atlassian.net/browse/K8SPS-623
DESCRIPTION
Problem:
It is currently possible to create a GCS backup only when
ACCESS_KEY_ID,SECRET_ACCESS_KEY,AWS_ACCESS_KEY_ID, andAWS_SECRET_ACCESS_KEYare provided, even though only GCS credentials should be required.Cause:
The validation function incorrectly checks for AWS-prefixed keys in the secret when validating GCS storage, while the backup job uses non-AWS-prefixed keys.
Solution:
Update the storage validation logic to use GCS-specific secret keys instead of AWS-prefixed keys.
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
Config/Logging/Testability