Skip to content

K8SPS-353 add required pitr binlog fields#823

Merged
gkech merged 2 commits intomainfrom
K8SPS-353-required-fields-pitr
Jan 29, 2025
Merged

K8SPS-353 add required pitr binlog fields#823
gkech merged 2 commits intomainfrom
K8SPS-353-required-fields-pitr

Conversation

@gkech
Copy link
Copy Markdown
Contributor

@gkech gkech commented Jan 28, 2025

K8SPS-353 Powered by Pull Request Badge

CHANGE DESCRIPTION

Problem:
We want to offer as required the pitr configs that were not until now, for binlog storage.

Cause:
Short explanation of the root cause of the issue if applicable.

Solution:
Short explanation of the solution we are providing with this PR.

Testing:

Screenshot 2025-01-28 at 5 50 20 PM

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PS version?
  • Does the change support oldest and newest supported Kubernetes version?

@pull-request-size pull-request-size bot added the size/M 30-99 lines label Jan 28, 2025
@gkech gkech force-pushed the K8SPS-353-required-fields-pitr branch from eb66e0f to 30942fd Compare January 28, 2025 15:49
@gkech gkech changed the title K8SPS-353 add required pitr fields K8SPS-353 add required pitr binlog fields Jan 28, 2025

// The number of seconds the MySQL client library will wait to establish a connection with a remote host
ConnectTimeout int32 `json:"connectTimeout,omitempty"`
ConnectTimeout int32 `json:"connectTimeout"`
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like the annotation from kubebuilder is not needed

@gkech gkech marked this pull request as ready for review January 28, 2025 16:12
@JNKPercona
Copy link
Copy Markdown
Collaborator

Test name Status
version-service passed
async-ignore-annotations passed
auto-config passed
config passed
config-router passed
demand-backup passed
gr-demand-backup passed
gr-demand-backup-haproxy passed
gr-finalizer passed
gr-haproxy passed
gr-ignore-annotations passed
gr-init-deploy passed
gr-one-pod passed
gr-recreate passed
gr-scaling passed
gr-scheduled-backup passed
gr-security-context passed
gr-self-healing passed
gr-tls-cert-manager passed
gr-users passed
haproxy passed
init-deploy passed
limits passed
monitoring passed
one-pod passed
operator-self-healing passed
recreate passed
scaling passed
scheduled-backup passed
service-per-pod passed
sidecars passed
smart-update passed
tls-cert-manager passed
users passed
We run 34 out of 34

commit: 393029a
image: perconalab/percona-server-mysql-operator:PR-823-393029a3

@gkech gkech merged commit 0ae19a9 into main Jan 29, 2025
11 checks passed
@gkech gkech deleted the K8SPS-353-required-fields-pitr branch January 29, 2025 08:49
mgumz pushed a commit to travelping/percona-server-mysql-operator that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M 30-99 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants