Skip to content

K8SPS-392: configure bootstrap readTimeout#838

Merged
egegunes merged 5 commits intomainfrom
K8SPS-392
Mar 7, 2025
Merged

K8SPS-392: configure bootstrap readTimeout#838
egegunes merged 5 commits intomainfrom
K8SPS-392

Conversation

@pooknull
Copy link
Copy Markdown
Contributor

@pooknull pooknull commented Feb 24, 2025

K8SPS-392 Powered by Pull Request Badge

https://perconadev.atlassian.net/browse/K8SPS-392

DESCRIPTION

Problem:
The clone operation in the bootstrap binary can take a long time to execute, potentially exceeding the timeout limit.

Solution:
The readTimeout should be configurable when establishing new database connections. To address this, the BOOTSTRAP_READ_TIMEOUT env var has been introduced in the bootstrap binary.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PS version?
  • Does the change support oldest and newest supported Kubernetes version?

@pull-request-size pull-request-size bot added the size/L 100-499 lines label Feb 24, 2025
@pooknull pooknull marked this pull request as ready for review February 24, 2025 17:53
egegunes
egegunes previously approved these changes Feb 27, 2025
cmd/db/db.go Outdated
Host string
Port int32

ReadTimeout uint32 // in seconds
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could incorporate the seconds property to the name of the variable e.g. ReadTimeoutSeconds. This will make it more clear throughout the codebase without having to rely on the comment to clarify it.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JNKPercona
Copy link
Copy Markdown
Collaborator

Test name Status
version-service passed
async-ignore-annotations passed
auto-config passed
config passed
config-router passed
demand-backup passed
gr-demand-backup passed
gr-demand-backup-haproxy passed
gr-finalizer passed
gr-haproxy passed
gr-ignore-annotations passed
gr-init-deploy passed
gr-one-pod passed
gr-recreate passed
gr-scaling passed
gr-scheduled-backup passed
gr-security-context passed
gr-self-healing passed
gr-tls-cert-manager passed
gr-users passed
haproxy passed
init-deploy passed
limits passed
monitoring passed
one-pod passed
operator-self-healing passed
recreate passed
scaling passed
scheduled-backup passed
service-per-pod passed
sidecars passed
smart-update passed
tls-cert-manager passed
users passed
We run 34 out of 34

commit: 9ddcbbe
image: perconalab/percona-server-mysql-operator:PR-838-9ddcbbe8

@egegunes egegunes merged commit 37fb9c5 into main Mar 7, 2025
16 checks passed
@egegunes egegunes deleted the K8SPS-392 branch March 7, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L 100-499 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants