Conversation
egegunes
previously approved these changes
Feb 27, 2025
gkech
reviewed
Feb 27, 2025
cmd/db/db.go
Outdated
| Host string | ||
| Port int32 | ||
|
|
||
| ReadTimeout uint32 // in seconds |
Contributor
There was a problem hiding this comment.
I think we could incorporate the seconds property to the name of the variable e.g. ReadTimeoutSeconds. This will make it more clear throughout the codebase without having to rely on the comment to clarify it.
gkech
approved these changes
Mar 4, 2025
egegunes
approved these changes
Mar 7, 2025
Collaborator
commit: 9ddcbbe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/K8SPS-392
DESCRIPTION
Problem:
The clone operation in the bootstrap binary can take a long time to execute, potentially exceeding the timeout limit.
Solution:
The
readTimeoutshould be configurable when establishing new database connections. To address this, theBOOTSTRAP_READ_TIMEOUTenv var has been introduced in the bootstrap binary.CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
Config/Logging/Testability