Skip to content

K8SPS-393 PMM3 support#849

Merged
hors merged 4 commits intomainfrom
K8SPS-393
Mar 4, 2025
Merged

K8SPS-393 PMM3 support#849
hors merged 4 commits intomainfrom
K8SPS-393

Conversation

@gkech
Copy link
Copy Markdown
Contributor

@gkech gkech commented Feb 28, 2025

K8SPS-393 Powered by Pull Request Badge

CHANGE DESCRIPTION

Problem:
With this PR we introduce the PMM3 support for the ps operator. We completely stop supporting PMM2, so the included changes remove completely PMM2 related configurations and references.

An example of using PMM server v3 and PMM client v3.

Screenshot 2025-03-03 at 5 10 28 AM

Screenshot 2025-03-03 at 5 13 47 AM

Cause:
Short explanation of the root cause of the issue if applicable.

Solution:
Short explanation of the solution we are providing with this PR.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PS version?
  • Does the change support oldest and newest supported Kubernetes version?

@pull-request-size pull-request-size bot added the size/L 100-499 lines label Feb 28, 2025
@gkech gkech changed the title K8SPS-393 K8SPS-393 PMM3 support Mar 3, 2025
@gkech gkech force-pushed the K8SPS-393 branch 2 times, most recently from 1f74008 to 821b75a Compare March 3, 2025 03:02
Comment on lines +184 to +185
- name: PMM_AGENT_PRERUN_SCRIPT
value: "/opt/percona/pmm-prerun.sh"
Copy link
Copy Markdown
Contributor Author

@gkech gkech Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gkech check why this env var is not references in the PMM documentation

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ticket created

@gkech gkech marked this pull request as ready for review March 3, 2025 03:15
egegunes
egegunes previously approved these changes Mar 3, 2025
hors
hors previously approved these changes Mar 3, 2025
@hors hors dismissed stale reviews from egegunes and themself via 6978c3b March 3, 2025 20:55
@JNKPercona
Copy link
Copy Markdown
Collaborator

Test name Status
version-service failure
async-ignore-annotations passed
auto-config passed
config passed
config-router passed
demand-backup passed
gr-demand-backup passed
gr-demand-backup-haproxy passed
gr-finalizer passed
gr-haproxy passed
gr-ignore-annotations passed
gr-init-deploy passed
gr-one-pod passed
gr-recreate passed
gr-scaling passed
gr-scheduled-backup passed
gr-security-context passed
gr-self-healing passed
gr-tls-cert-manager passed
gr-users passed
haproxy passed
init-deploy passed
limits passed
monitoring passed
one-pod passed
operator-self-healing passed
recreate passed
scaling passed
scheduled-backup passed
service-per-pod passed
sidecars passed
smart-update passed
tls-cert-manager passed
users passed
We run 34 out of 34

commit: 6978c3b
image: perconalab/percona-server-mysql-operator:PR-849-6978c3b9

@gkech gkech requested review from egegunes and hors March 4, 2025 08:57
@hors hors merged commit 43da21a into main Mar 4, 2025
14 of 16 checks passed
@hors hors deleted the K8SPS-393 branch March 4, 2025 10:07
Comment on lines 88 to 91
{
Name: "PMM_AGENT_CONFIG_FILE",
Value: "/usr/local/percona/pmm2/config/pmm-agent.yaml",
Value: "/usr/local/percona/pmm/config/pmm-agent.yaml",
},
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, since it's default value even without env variable, what's the reason to override it?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change will drop pmm2 support by the operator

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct, we are not going to support PMM2 on the PS operator. We will keep support both for PMM2 and PMM3 for all the other operators i.e. pxc, psmdb and pgo

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @hors

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BupycHuk PS operator will be GA only in the end of Q3, so we decided to release GA only with PMM3 support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L 100-499 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants